From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH libdrm] tests/util: Add support for meson module Date: Fri, 20 Jan 2017 17:17:39 +0100 Message-ID: <20170120161739.GA28228@ulmo.ba.sec> References: <1484747961-5418-1-git-send-email-narmstrong@baylibre.com> <20170119091955.GA29394@ulmo.ba.sec> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0241777579==" Return-path: Received: from hqemgate14.nvidia.com (hqemgate14.nvidia.com [216.228.121.143]) by gabe.freedesktop.org (Postfix) with ESMTPS id C18176EBF6 for ; Fri, 20 Jan 2017 16:17:52 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov Cc: ML dri-devel , Neil Armstrong List-Id: dri-devel@lists.freedesktop.org --===============0241777579== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VbJkn9YxBvnuCH5J" Content-Disposition: inline --VbJkn9YxBvnuCH5J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 20, 2017 at 02:13:00PM +0000, Emil Velikov wrote: > On 19 January 2017 at 09:19, Thierry Reding wrote: > > On Wed, Jan 18, 2017 at 02:59:21PM +0100, Neil Armstrong wrote: > >> Add support for Amlogic Meson DRM driver merged for Linux 4.10. > >> > >> Signed-off-by: Neil Armstrong > >> --- > >> tests/util/kms.c | 1 + > >> 1 file changed, 1 insertion(+) > > > > Applied, thanks. > > > Was going to say "NACK use Thierry's helpers" but you've beat me to it. > As a Tl;DR: we _really_ want to stop using drmOpen* for anything that's KMS. I think it's still useful to have this helper to iterate over all supported driver because it enables easy testing with just a simple modetest. That said, for (almost) as long as I remember I've been using the -M option to prevent modetest from iterating over the list, which can take fairly long if you've got DRM_DEBUG messages enabled. I'm not sure I understand exactly what you're suggesting by "use Thierry's helpers". modetest and other tests use util_open() internally now. That in turn uses drmOpen(), though we're of course open to change that. Are you suggesting we somehow use drmDevice to locate existing devices? We could implement some heuristic that finds the first device with a primary node, but what if we want to support the -M option? There is currently no way of getting the driver from drmDevice. Maybe that's something we should add anyway. Thierry --VbJkn9YxBvnuCH5J Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAliCOCEACgkQ3SOs138+ s6HNMQ/8CQzC4wpONXc9kyk0lCKXJbrOH8ildEzKPvl73ua5sO1yO/JmGwG0fkHl SeF8Vza96Ycqy4vR8Inw7e2M6yY2ZKm4c/jMc3XpJe01JqrZ49P4oxCOu2BKObSL +Z/N82xNk0NDs+VZdZuzGGfgHtLutjCD8QiUgFQ7FH0gcxa04pigvVVYvKvpdLrW wIK1XkEcR75L9CJRpgpfDUZx7vLSHr8PWMB08cKkEmCnS8VKhtv3/ydnfxjc2yAt XJnMOa4Z3QnmINqUKe6KoaF3jtQ3UbmUp28ObNGm6AR+k4/YAeHvJV8GyOW5/SrO qjFJH+MIz1IlDeKArIbBC7bi9JD6BDv55mRdj2nBlCdcfiBl203LhypJq0jbTvxP cbJQ4qdYPKK+VKVp7q5E/OjZiAVIzTrdkTw4QuOIcyAyxybBoA375hbZS8crshwl pu9Z5srKOJpiaPITp8ByWuZbuL7aNgtfuoRTN6pMwnSsmfP/3ru0GAh062l7xAVS KYhdeZ2dB0EpNZOVuZQ2ePZNkaV4Ku6KdN/G5MExUk0WvsbIP5kj6u8nQ6TNlrFL x61v8UkHTY8gQ2B49xFySj406jw6tPZvzESPjb+7e1ED/lOncoQUpNpruI9wfA7P 5FJ/7vm6y+4bQmPLcUvxo5jbg6iUvUFm/MZUXP69jVlQ+dwaGcw= =DVlo -----END PGP SIGNATURE----- --VbJkn9YxBvnuCH5J-- --===============0241777579== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0241777579==--