All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Farman <farman@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: Eric Farman <farman@linux.vnet.ibm.com>,
	kwolf@redhat.com, mreitz@redhat.com
Subject: [Qemu-devel] [PATCH v3 3/3] block: get max_transfer limit for char (scsi-generic) devices
Date: Fri, 20 Jan 2017 17:25:27 +0100	[thread overview]
Message-ID: <20170120162527.66075-4-farman@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170120162527.66075-1-farman@linux.vnet.ibm.com>

We can get the maximum number of bytes for a single I/O transfer
from the BLKSECTGET ioctl, but we only perform this for block
devices.  scsi-generic devices are represented as character devices,
and so do not issue this today.  Update this, so that virtio-scsi
devices using the scsi-generic interface can return the same data.

Signed-off-by: Eric Farman <farman@linux.vnet.ibm.com>
---
 block/file-posix.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/file-posix.c b/block/file-posix.c
index 9f83725..2134e0e 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -674,7 +674,7 @@ static void raw_refresh_limits(BlockDriverState *bs, Error **errp)
     struct stat st;
 
     if (!fstat(s->fd, &st)) {
-        if (S_ISBLK(st.st_mode)) {
+        if (S_ISBLK(st.st_mode) || S_ISCHR(st.st_mode)) {
             int ret = hdev_get_max_transfer_length(bs, s->fd);
             if (ret > 0 && ret <= BDRV_REQUEST_MAX_BYTES) {
                 bs->bl.max_transfer = pow2floor(ret);
-- 
2.8.4

  parent reply	other threads:[~2017-01-20 16:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-20 16:25 [Qemu-devel] [PATCH v3 0/3] scsi-generic and BLKSECTGET Eric Farman
2017-01-20 16:25 ` [Qemu-devel] [PATCH v3 1/3] hw/scsi: Fix debug message of cdb structure in scsi-generic Eric Farman
2017-01-20 16:25 ` [Qemu-devel] [PATCH v3 2/3] block: Fix target variable of BLKSECTGET ioctl Eric Farman
2017-02-01  0:25   ` [Qemu-devel] [Qemu-block] " Max Reitz
2017-02-01 13:18     ` Eric Farman
2017-01-20 16:25 ` Eric Farman [this message]
2017-01-22 14:29 ` [Qemu-devel] [PATCH v3 0/3] scsi-generic and BLKSECTGET Fam Zheng
2017-01-24 11:23   ` Paolo Bonzini
2017-01-24 12:09     ` Fam Zheng
2017-01-24 12:17       ` Eric Farman
2017-01-31 11:37       ` [Qemu-devel] [Qemu-block] " John Snow
2017-01-31 23:47         ` Max Reitz
2017-02-01  9:51           ` John Snow
2017-02-01 19:55 ` Max Reitz
2017-02-08 22:33   ` Max Reitz
2017-02-09  9:32     ` [Qemu-devel] " Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170120162527.66075-4-farman@linux.vnet.ibm.com \
    --to=farman@linux.vnet.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.