From: andrew@lunn.ch (Andrew Lunn)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v3 2/9] ARM64: dts: meson-gxbb-p200: add the ethernet PHY's reset GPIO
Date: Fri, 20 Jan 2017 18:46:58 +0100 [thread overview]
Message-ID: <20170120174658.GG25907@lunn.ch> (raw)
In-Reply-To: <CAFBinCA47Nng_jjxKrWrV_YBHr0bg+7xPaJrVswt_WnZ6wtyjA@mail.gmail.com>
On Fri, Jan 20, 2017 at 06:07:20PM +0100, Martin Blumenstingl wrote:
> I though that this is good practice - the documentation doesn't say
> that it should only be added in specific cases: [0]
Agreed, the text should be better, listing when it is appropriate to
use.
> my intention behind adding the PHY ID was to make it easier to see
> which devices uses which PHY. this is especially useful for devices
> with RTL8211F PHY (basically all devices with RGMII PHY except the
> P200) as these may need similar fixes than [1]
I would not say it is wrong to list the PHY ID, it just has
consequences if the PHY ever changes.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/9] ARM64: dts: meson-gxbb-p200: add the ethernet PHY's reset GPIO
Date: Fri, 20 Jan 2017 18:46:58 +0100 [thread overview]
Message-ID: <20170120174658.GG25907@lunn.ch> (raw)
In-Reply-To: <CAFBinCA47Nng_jjxKrWrV_YBHr0bg+7xPaJrVswt_WnZ6wtyjA@mail.gmail.com>
On Fri, Jan 20, 2017 at 06:07:20PM +0100, Martin Blumenstingl wrote:
> I though that this is good practice - the documentation doesn't say
> that it should only be added in specific cases: [0]
Agreed, the text should be better, listing when it is appropriate to
use.
> my intention behind adding the PHY ID was to make it easier to see
> which devices uses which PHY. this is especially useful for devices
> with RTL8211F PHY (basically all devices with RGMII PHY except the
> P200) as these may need similar fixes than [1]
I would not say it is wrong to list the PHY ID, it just has
consequences if the PHY ever changes.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Martin Blumenstingl
<martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
Cc: linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
catalin.marinas-5wv7dgnIgG8@public.gmane.org,
will.deacon-5wv7dgnIgG8@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
jbrunet-rdvid1DuHRBWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH v3 2/9] ARM64: dts: meson-gxbb-p200: add the ethernet PHY's reset GPIO
Date: Fri, 20 Jan 2017 18:46:58 +0100 [thread overview]
Message-ID: <20170120174658.GG25907@lunn.ch> (raw)
In-Reply-To: <CAFBinCA47Nng_jjxKrWrV_YBHr0bg+7xPaJrVswt_WnZ6wtyjA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Fri, Jan 20, 2017 at 06:07:20PM +0100, Martin Blumenstingl wrote:
> I though that this is good practice - the documentation doesn't say
> that it should only be added in specific cases: [0]
Agreed, the text should be better, listing when it is appropriate to
use.
> my intention behind adding the PHY ID was to make it easier to see
> which devices uses which PHY. this is especially useful for devices
> with RTL8211F PHY (basically all devices with RGMII PHY except the
> P200) as these may need similar fixes than [1]
I would not say it is wrong to list the PHY ID, it just has
consequences if the PHY ever changes.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-01-20 17:46 UTC|newest]
Thread overview: 234+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 23:47 [PATCH 0/5] meson-gx: reset RGMII PHYs and configure TX delay Martin Blumenstingl
2016-12-02 23:47 ` Martin Blumenstingl
2016-12-02 23:47 ` Martin Blumenstingl
2016-12-02 23:47 ` [PATCH 1/5] ARM64: dts: meson-gx: move the MDIO node to meson-gx Martin Blumenstingl
2016-12-02 23:47 ` Martin Blumenstingl
2016-12-02 23:47 ` Martin Blumenstingl
2016-12-02 23:47 ` [PATCH 2/5] ARM64: dts: meson-gxbb-odroidc2: add reset for the ethernet PHY Martin Blumenstingl
2016-12-02 23:47 ` Martin Blumenstingl
2016-12-02 23:47 ` Martin Blumenstingl
2016-12-02 23:47 ` [PATCH 3/5] ARM64: dts: meson-gxbb-p20x: " Martin Blumenstingl
2016-12-02 23:47 ` Martin Blumenstingl
2016-12-02 23:47 ` Martin Blumenstingl
2017-01-17 19:22 ` Jerome Brunet
2017-01-17 19:22 ` Jerome Brunet
2017-01-17 19:22 ` Jerome Brunet
2017-01-17 21:26 ` Martin Blumenstingl
2017-01-17 21:26 ` Martin Blumenstingl
2017-01-17 21:26 ` Martin Blumenstingl
2017-01-18 10:36 ` Jerome Brunet
2017-01-18 10:36 ` Jerome Brunet
2017-01-18 10:36 ` Jerome Brunet
2017-01-18 14:26 ` Martin Blumenstingl
2017-01-18 14:26 ` Martin Blumenstingl
2017-01-18 14:26 ` Martin Blumenstingl
2016-12-02 23:47 ` [PATCH 4/5] ARM64: dts: meson-gxbb-vega-s95: " Martin Blumenstingl
2016-12-02 23:47 ` Martin Blumenstingl
2016-12-02 23:47 ` Martin Blumenstingl
2016-12-02 23:47 ` [PATCH 5/5] ARM64: dts: amlogic: add the ethernet TX delay configuration Martin Blumenstingl
2016-12-02 23:47 ` Martin Blumenstingl
2016-12-02 23:47 ` Martin Blumenstingl
2016-12-17 20:36 ` [PATCH 0/5] meson-gx: reset RGMII PHYs and configure TX delay Martin Blumenstingl
2016-12-17 20:36 ` Martin Blumenstingl
2016-12-17 20:36 ` Martin Blumenstingl
2017-01-09 22:52 ` Kevin Hilman
2017-01-09 22:52 ` Kevin Hilman
2017-01-09 22:52 ` Kevin Hilman
2017-01-17 19:23 ` Jerome Brunet
2017-01-17 19:23 ` Jerome Brunet
2017-01-17 19:23 ` Jerome Brunet
2017-01-17 21:09 ` Martin Blumenstingl
2017-01-17 21:09 ` Martin Blumenstingl
2017-01-17 21:09 ` Martin Blumenstingl
2017-01-17 22:26 ` Jerome Brunet
2017-01-17 22:26 ` Jerome Brunet
2017-01-17 22:26 ` Jerome Brunet
2017-01-17 22:44 ` Martin Blumenstingl
2017-01-17 22:44 ` Martin Blumenstingl
2017-01-17 22:44 ` Martin Blumenstingl
2017-01-18 19:28 ` Kevin Hilman
2017-01-18 19:28 ` Kevin Hilman
2017-01-18 19:28 ` Kevin Hilman
2017-01-18 19:40 ` Martin Blumenstingl
2017-01-18 19:40 ` Martin Blumenstingl
2017-01-18 19:40 ` Martin Blumenstingl
2017-01-19 9:47 ` Jerome Brunet
2017-01-19 9:47 ` Jerome Brunet
2017-01-19 9:47 ` Jerome Brunet
2017-01-20 13:26 ` [PATCH v2 0/9] " Martin Blumenstingl
2017-01-20 13:26 ` Martin Blumenstingl
2017-01-20 13:26 ` Martin Blumenstingl
2017-01-20 13:26 ` [PATCH v2 1/9] ARM64: dts: meson-gxbb-odroidc2: add the ethernet PHY's reset GPIO Martin Blumenstingl
2017-01-20 13:26 ` Martin Blumenstingl
2017-01-20 13:26 ` Martin Blumenstingl
2017-01-20 13:26 ` [PATCH v2 2/9] ARM64: dts: meson-gxbb-p201: " Martin Blumenstingl
2017-01-20 13:26 ` Martin Blumenstingl
2017-01-20 13:26 ` Martin Blumenstingl
2017-01-20 13:31 ` Neil Armstrong
2017-01-20 13:31 ` Neil Armstrong
2017-01-20 13:31 ` Neil Armstrong
2017-01-20 13:33 ` Martin Blumenstingl
2017-01-20 13:33 ` Martin Blumenstingl
2017-01-20 13:33 ` Martin Blumenstingl
2017-01-20 13:26 ` [PATCH v2 3/9] ARM64: dts: meson-gxbb-vega-s95: " Martin Blumenstingl
2017-01-20 13:26 ` Martin Blumenstingl
2017-01-20 13:26 ` Martin Blumenstingl
2017-01-20 13:26 ` [PATCH v2 4/9] ARM64: dts: meson-gxbb-nexbox-a95x: " Martin Blumenstingl
2017-01-20 13:26 ` Martin Blumenstingl
2017-01-20 13:26 ` Martin Blumenstingl
2017-01-20 13:26 ` [PATCH v2 5/9] ARM64: dts: meson-gxbb-wetek-hub: " Martin Blumenstingl
2017-01-20 13:26 ` Martin Blumenstingl
2017-01-20 13:26 ` Martin Blumenstingl
2017-01-20 13:26 ` [PATCH v2 6/9] ARM64: dts: meson-gxbb-wetek-play2: " Martin Blumenstingl
2017-01-20 13:26 ` Martin Blumenstingl
2017-01-20 13:26 ` Martin Blumenstingl
2017-01-20 13:26 ` [PATCH v2 7/9] ARM64: dts: meson-gxbb-p20x: remove the ethernet node Martin Blumenstingl
2017-01-20 13:26 ` Martin Blumenstingl
2017-01-20 13:26 ` Martin Blumenstingl
2017-01-20 13:26 ` [PATCH v2 8/9] ARM64: dts: amlogic: add the ethernet TX delay configuration Martin Blumenstingl
2017-01-20 13:26 ` Martin Blumenstingl
2017-01-20 13:26 ` Martin Blumenstingl
2017-01-20 13:26 ` [PATCH v2 9/9] ARM64: dts: meson-gx: remove the phy-mode property from meson-gx Martin Blumenstingl
2017-01-20 13:26 ` Martin Blumenstingl
2017-01-20 13:26 ` Martin Blumenstingl
2017-01-20 15:22 ` [PATCH v3 0/9] meson-gx: reset RGMII PHYs and configure TX delay Martin Blumenstingl
2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 15:22 ` [PATCH v3 1/9] ARM64: dts: meson-gxbb-odroidc2: add the ethernet PHY's reset GPIO Martin Blumenstingl
2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 16:23 ` Neil Armstrong
2017-01-20 16:23 ` Neil Armstrong
2017-01-20 16:23 ` Neil Armstrong
2017-01-20 15:22 ` [PATCH v3 2/9] ARM64: dts: meson-gxbb-p200: " Martin Blumenstingl
2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 16:18 ` Andrew Lunn
2017-01-20 16:18 ` Andrew Lunn
2017-01-20 16:18 ` Andrew Lunn
2017-01-20 16:21 ` Andrew Lunn
2017-01-20 16:21 ` Andrew Lunn
2017-01-20 16:21 ` Andrew Lunn
2017-01-20 17:07 ` Martin Blumenstingl
2017-01-20 17:07 ` Martin Blumenstingl
2017-01-20 17:07 ` Martin Blumenstingl
2017-01-20 17:46 ` Andrew Lunn [this message]
2017-01-20 17:46 ` Andrew Lunn
2017-01-20 17:46 ` Andrew Lunn
2017-01-22 16:48 ` Martin Blumenstingl
2017-01-22 16:48 ` Martin Blumenstingl
2017-01-22 16:48 ` Martin Blumenstingl
2017-01-20 16:23 ` Neil Armstrong
2017-01-20 16:23 ` Neil Armstrong
2017-01-20 16:23 ` Neil Armstrong
2017-01-20 15:22 ` [PATCH v3 3/9] ARM64: dts: meson-gxbb-vega-s95: " Martin Blumenstingl
2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 15:22 ` [PATCH v3 4/9] ARM64: dts: meson-gxbb-nexbox-a95x: " Martin Blumenstingl
2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 16:23 ` Neil Armstrong
2017-01-20 16:23 ` Neil Armstrong
2017-01-20 16:23 ` Neil Armstrong
2017-01-20 15:22 ` [PATCH v3 5/9] ARM64: dts: meson-gxbb-wetek-hub: " Martin Blumenstingl
2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 15:22 ` [PATCH v3 6/9] ARM64: dts: meson-gxbb-wetek-play2: " Martin Blumenstingl
2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 16:23 ` Neil Armstrong
2017-01-20 16:23 ` Neil Armstrong
2017-01-20 16:23 ` Neil Armstrong
2017-01-20 15:22 ` [PATCH v3 7/9] ARM64: dts: meson-gxbb-p201: fix ethernet support Martin Blumenstingl
2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 15:22 ` [PATCH v3 8/9] ARM64: dts: amlogic: add the ethernet TX delay configuration Martin Blumenstingl
2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 16:34 ` Neil Armstrong
2017-01-20 16:34 ` Neil Armstrong
2017-01-20 16:34 ` Neil Armstrong
2017-01-20 15:22 ` [PATCH v3 9/9] ARM64: dts: meson-gx: remove the phy-mode property from meson-gx Martin Blumenstingl
2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 15:22 ` Martin Blumenstingl
2017-01-20 15:27 ` [PATCH v3 0/9] meson-gx: reset RGMII PHYs and configure TX delay Jerome Brunet
2017-01-20 15:27 ` Jerome Brunet
2017-01-20 15:27 ` Jerome Brunet
2017-01-20 15:32 ` Martin Blumenstingl
2017-01-20 15:32 ` Martin Blumenstingl
2017-01-20 15:32 ` Martin Blumenstingl
2017-01-20 19:46 ` Kevin Hilman
2017-01-20 19:46 ` Kevin Hilman
2017-01-20 19:46 ` Kevin Hilman
2017-01-22 18:10 ` [PATCH v4 " Martin Blumenstingl
2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` [PATCH v4 1/9] ARM64: dts: meson-gxbb-odroidc2: add the ethernet PHY's reset GPIO Martin Blumenstingl
2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` [PATCH v4 2/9] ARM64: dts: meson-gxbb-p200: " Martin Blumenstingl
2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` [PATCH v4 3/9] ARM64: dts: meson-gxbb-vega-s95: " Martin Blumenstingl
2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` [PATCH v4 4/9] ARM64: dts: meson-gxbb-nexbox-a95x: " Martin Blumenstingl
2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` [PATCH v4 5/9] ARM64: dts: meson-gxbb-wetek-hub: " Martin Blumenstingl
2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` [PATCH v4 6/9] ARM64: dts: meson-gxbb-wetek-play2: " Martin Blumenstingl
2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` [PATCH v4 7/9] ARM64: dts: meson-gxbb-p201: fix ethernet support Martin Blumenstingl
2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` [PATCH v4 8/9] ARM64: dts: amlogic: add the ethernet TX delay configuration Martin Blumenstingl
2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` [PATCH v4 9/9] ARM64: dts: meson-gx: remove the phy-mode property from meson-gx Martin Blumenstingl
2017-01-22 18:10 ` Martin Blumenstingl
2017-01-22 18:10 ` Martin Blumenstingl
2017-01-23 18:55 ` [PATCH v4 0/9] meson-gx: reset RGMII PHYs and configure TX delay Kevin Hilman
2017-01-23 18:55 ` Kevin Hilman
2017-01-23 18:55 ` Kevin Hilman
2017-01-23 19:02 ` Martin Blumenstingl
2017-01-23 19:02 ` Martin Blumenstingl
2017-01-23 19:02 ` Martin Blumenstingl
2017-02-19 21:41 ` [PATCH v5 " Martin Blumenstingl
2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` [PATCH v5 1/9] ARM64: dts: meson-gxbb-odroidc2: add the ethernet PHY's reset GPIO Martin Blumenstingl
2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` [PATCH v5 2/9] ARM64: dts: meson-gxbb-p200: " Martin Blumenstingl
2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` [PATCH v5 3/9] ARM64: dts: meson-gxbb-vega-s95: " Martin Blumenstingl
2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` [PATCH v5 4/9] ARM64: dts: meson-gxbb-nexbox-a95x: " Martin Blumenstingl
2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` [PATCH v5 5/9] ARM64: dts: meson-gxbb-wetek-hub: " Martin Blumenstingl
2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` [PATCH v5 6/9] ARM64: dts: meson-gxbb-wetek-play2: " Martin Blumenstingl
2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` [PATCH v5 7/9] ARM64: dts: meson-gxbb-p201: fix ethernet support Martin Blumenstingl
2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` [PATCH v5 8/9] ARM64: dts: amlogic: add the ethernet TX delay configuration Martin Blumenstingl
2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` [PATCH v5 9/9] ARM64: dts: meson-gx: remove the phy-mode property from meson-gx Martin Blumenstingl
2017-02-19 21:41 ` Martin Blumenstingl
2017-02-19 21:41 ` Martin Blumenstingl
2017-02-20 9:08 ` [PATCH v5 0/9] meson-gx: reset RGMII PHYs and configure TX delay Jerome Brunet
2017-02-20 9:08 ` Jerome Brunet
2017-02-20 9:08 ` Jerome Brunet
2017-03-02 17:02 ` Kevin Hilman
2017-03-02 17:02 ` Kevin Hilman
2017-03-02 17:02 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170120174658.GG25907@lunn.ch \
--to=andrew@lunn.ch \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.