From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/2] drm/i915: Remove crtc->config usage from intel_modeset_readout_hw_state() Date: Fri, 20 Jan 2017 21:58:11 +0200 Message-ID: <20170120195811.GJ31595@intel.com> References: <20161222140442.7204-1-ville.syrjala@linux.intel.com> <20161227145654.GF31952@dvetter-linux.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8B3886E1EE for ; Fri, 20 Jan 2017 19:58:14 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20161227145654.GF31952@dvetter-linux.ger.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBEZWMgMjcsIDIwMTYgYXQgMDM6NTY6NTRQTSArMDEwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBUaHUsIERlYyAyMiwgMjAxNiBhdCAwNDowNDo0MVBNICswMjAwLCB2aWxsZS5z eXJqYWxhQGxpbnV4LmludGVsLmNvbSB3cm90ZToKPiA+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8 dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAKPiA+IGNydGMtPmNvbmZpZyBpcyBv biBpdHMgd2F5IG91dC4gTGV0J3MgcmVkdWNlIG91ciBkZXBlbmRlbmNlIG9uIGl0IGEKPiA+IGxp dHRsZSBiaXQgYnkgcmVtb3ZpbmcgaXQgZnJvbSBpbnRlbF9tb2Rlc2V0X3JlYWRvdXRfaHdfc3Rh dGUoKS4KPiA+IAo+ID4gQWxzbyByZXBsYWNlIGNydGMtPmFjdHRpdmUgY2hlY2tzIHdpdGggY3J0 Y19zdGF0ZS0+YmFzZS5hY3RpdmUgY2hlY2tzLgo+ID4gCj4gPiBDYzogTWFhcnRlbiBMYW5raG9y c3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiA+IFN1Z2dlc3RlZC1ieTog TWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiA+ IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRl bC5jb20+Cj4gCj4gUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3 bGwuY2g+CgpQdXNoZWQgYm90aCBwYXRjaGVzIHRvIGRpbnEuIFRoYW5rcyBmb3IgdGhlIHJldmll d3MuCgo+IAo+IElkbGluZyBtdXNpbmc6IEkgd29uZGVyIHdoZXRoZXIgd2Ugc2hvdWxkIGNvbnZl cnQgdGhlIHJlYWRvdXQgY29kZSB0byB1c2UKPiBhbiBlbnRpcmVseSBmcmVlLXN0YW5kaW5nIGF0 b21pYyBzdGF0aWMgdHJhY2tlZCBpbiBkcm1fYXRvbWljX2NvbW1pdC4gQW5kCj4gdGhlbiBhcHBs eSBpdCB3aXRoIGEgZGlyZWN0bHkgY2FsbCB0byBzd2FwX3N0YXRlLiBUaGF0IHdheSB3ZSBjb3Vs ZCByZXVzZQo+IGFsbCB0aGUgbmVhdCBpdGVyYXRvcnMuCj4gCj4gTm90IHN1cmUgdGhhdCdzIGEg Z29vZCBpZGVhIHRob3VnaC4KCkhtbS4gTWF5YmUuCgpBdCBzb21lIHBvaW50IEkgd2FzIHRveWlu ZyB3aXRoIHRoZSBpZGVhIG9mIG1ha2luZyB0aGUgb2xkIExWRFMvRFZPCmludGVsX2NydGNfbW9k ZV9nZXQoKSB0aGluZyB1c2UgdGhlIG5vcm1hbCByZWFkb3V0IHBhdGhzLCBidXQgSSB3YXMKc2xp Z2h0bHkgd29ycmllZCB0aGF0IHRoZSBsYWNrIG9mIHRoZSB0b3AgbGV2ZWwgYXRvbWljIHN0YXRl IGNvdWxkIGhhdmUKYmVlbiBhIHByb2JsZW0uIEkgZG9uJ3QgdGhpbmsgaXQgYWN0dWFsbHkgd2Fz IGZvciB0aGUgcGxhdGZvcm1zIHdoZXJlCnRoYXQgY29kZXBhdGggY2FuIGJlIHRha2VuLCBidXQg SSBkaWQgaGF2ZSB0byB0aGluayBhYm91dCBpdCBhIGJpdCBhdApsZWFzdC4KCj4gLURhbmllbAo+ IAo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgMzgg KysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQs IDI0IGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBpbmRleCBkOGVmZmQ0ZGEwMzQuLjA5MWMxOTJjNmM1YyAx MDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBAQCAtMTcwMzIs NyArMTcwMzIsOCBAQCBzdGF0aWMgdm9pZCBpbnRlbF9tb2Rlc2V0X3JlYWRvdXRfaHdfc3RhdGUo c3RydWN0IGRybV9kZXZpY2UgKmRldikKPiA+ICAJZGV2X3ByaXYtPmFjdGl2ZV9jcnRjcyA9IDA7 Cj4gPiAgCj4gPiAgCWZvcl9lYWNoX2ludGVsX2NydGMoZGV2LCBjcnRjKSB7Cj4gPiAtCQlzdHJ1 Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSA9IGNydGMtPmNvbmZpZzsKPiA+ICsJCXN0 cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlID0KPiA+ICsJCQl0b19pbnRlbF9jcnRj X3N0YXRlKGNydGMtPmJhc2Uuc3RhdGUpOwo+ID4gIAo+ID4gIAkJX19kcm1fYXRvbWljX2hlbHBl cl9jcnRjX2Rlc3Ryb3lfc3RhdGUoJmNydGNfc3RhdGUtPmJhc2UpOwo+ID4gIAkJbWVtc2V0KGNy dGNfc3RhdGUsIDAsIHNpemVvZigqY3J0Y19zdGF0ZSkpOwo+ID4gQEAgLTE3MDUxLDcgKzE3MDUy LDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfbW9kZXNldF9yZWFkb3V0X2h3X3N0YXRlKHN0cnVjdCBk cm1fZGV2aWNlICpkZXYpCj4gPiAgCj4gPiAgCQlEUk1fREVCVUdfS01TKCJbQ1JUQzolZDolc10g aHcgc3RhdGUgcmVhZG91dDogJXNcbiIsCj4gPiAgCQkJICAgICAgY3J0Yy0+YmFzZS5iYXNlLmlk LCBjcnRjLT5iYXNlLm5hbWUsCj4gPiAtCQkJICAgICAgZW5hYmxlZGRpc2FibGVkKGNydGMtPmFj dGl2ZSkpOwo+ID4gKwkJCSAgICAgIGVuYWJsZWRkaXNhYmxlZChjcnRjX3N0YXRlLT5iYXNlLmFj dGl2ZSkpOwo+ID4gIAl9Cj4gPiAgCj4gPiAgCWZvciAoaSA9IDA7IGkgPCBkZXZfcHJpdi0+bnVt X3NoYXJlZF9kcGxsOyBpKyspIHsKPiA+IEBAIC0xNzA2MSw3ICsxNzA2MiwxMSBAQCBzdGF0aWMg dm9pZCBpbnRlbF9tb2Rlc2V0X3JlYWRvdXRfaHdfc3RhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRl dikKPiA+ICAJCQkJCQkgICZwbGwtPmNvbmZpZy5od19zdGF0ZSk7Cj4gPiAgCQlwbGwtPmNvbmZp Zy5jcnRjX21hc2sgPSAwOwo+ID4gIAkJZm9yX2VhY2hfaW50ZWxfY3J0YyhkZXYsIGNydGMpIHsK PiA+IC0JCQlpZiAoY3J0Yy0+YWN0aXZlICYmIGNydGMtPmNvbmZpZy0+c2hhcmVkX2RwbGwgPT0g cGxsKQo+ID4gKwkJCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlID0KPiA+ICsJ CQkJdG9faW50ZWxfY3J0Y19zdGF0ZShjcnRjLT5iYXNlLnN0YXRlKTsKPiA+ICsKPiA+ICsJCQlp ZiAoY3J0Y19zdGF0ZS0+YmFzZS5hY3RpdmUgJiYKPiA+ICsJCQkgICAgY3J0Y19zdGF0ZS0+c2hh cmVkX2RwbGwgPT0gcGxsKQo+ID4gIAkJCQlwbGwtPmNvbmZpZy5jcnRjX21hc2sgfD0gMSA8PCBj cnRjLT5waXBlOwo+ID4gIAkJfQo+ID4gIAkJcGxsLT5hY3RpdmVfbWFzayA9IHBsbC0+Y29uZmln LmNydGNfbWFzazsKPiA+IEBAIC0xNzA3NCwxMSArMTcwNzksMTQgQEAgc3RhdGljIHZvaWQgaW50 ZWxfbW9kZXNldF9yZWFkb3V0X2h3X3N0YXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gPiAg CQlwaXBlID0gMDsKPiA+ICAKPiA+ICAJCWlmIChlbmNvZGVyLT5nZXRfaHdfc3RhdGUoZW5jb2Rl ciwgJnBpcGUpKSB7Cj4gPiArCQkJc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7 Cj4gPiArCj4gPiAgCQkJY3J0YyA9IGludGVsX2dldF9jcnRjX2Zvcl9waXBlKGRldl9wcml2LCBw aXBlKTsKPiA+ICsJCQljcnRjX3N0YXRlID0gdG9faW50ZWxfY3J0Y19zdGF0ZShjcnRjLT5iYXNl LnN0YXRlKTsKPiA+ICAKPiA+ICAJCQllbmNvZGVyLT5iYXNlLmNydGMgPSAmY3J0Yy0+YmFzZTsK PiA+IC0JCQljcnRjLT5jb25maWctPm91dHB1dF90eXBlcyB8PSAxIDw8IGVuY29kZXItPnR5cGU7 Cj4gPiAtCQkJZW5jb2Rlci0+Z2V0X2NvbmZpZyhlbmNvZGVyLCBjcnRjLT5jb25maWcpOwo+ID4g KwkJCWNydGNfc3RhdGUtPm91dHB1dF90eXBlcyB8PSAxIDw8IGVuY29kZXItPnR5cGU7Cj4gPiAr CQkJZW5jb2Rlci0+Z2V0X2NvbmZpZyhlbmNvZGVyLCBjcnRjX3N0YXRlKTsKPiA+ICAJCX0gZWxz ZSB7Cj4gPiAgCQkJZW5jb2Rlci0+YmFzZS5jcnRjID0gTlVMTDsKPiA+ICAJCX0KPiA+IEBAIC0x NzExOSwxNCArMTcxMjcsMTYgQEAgc3RhdGljIHZvaWQgaW50ZWxfbW9kZXNldF9yZWFkb3V0X2h3 X3N0YXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gPiAgCX0KPiA+ICAKPiA+ICAJZm9yX2Vh Y2hfaW50ZWxfY3J0YyhkZXYsIGNydGMpIHsKPiA+ICsJCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRl ICpjcnRjX3N0YXRlID0KPiA+ICsJCQl0b19pbnRlbF9jcnRjX3N0YXRlKGNydGMtPmJhc2Uuc3Rh dGUpOwo+ID4gIAkJaW50IHBpeGNsayA9IDA7Cj4gPiAgCj4gPiAtCQljcnRjLT5iYXNlLmh3bW9k ZSA9IGNydGMtPmNvbmZpZy0+YmFzZS5hZGp1c3RlZF9tb2RlOwo+ID4gKwkJY3J0Yy0+YmFzZS5o d21vZGUgPSBjcnRjX3N0YXRlLT5iYXNlLmFkanVzdGVkX21vZGU7Cj4gPiAgCj4gPiAgCQltZW1z ZXQoJmNydGMtPmJhc2UubW9kZSwgMCwgc2l6ZW9mKGNydGMtPmJhc2UubW9kZSkpOwo+ID4gLQkJ aWYgKGNydGMtPmJhc2Uuc3RhdGUtPmFjdGl2ZSkgewo+ID4gLQkJCWludGVsX21vZGVfZnJvbV9w aXBlX2NvbmZpZygmY3J0Yy0+YmFzZS5tb2RlLCBjcnRjLT5jb25maWcpOwo+ID4gLQkJCWludGVs X21vZGVfZnJvbV9waXBlX2NvbmZpZygmY3J0Yy0+YmFzZS5zdGF0ZS0+YWRqdXN0ZWRfbW9kZSwg Y3J0Yy0+Y29uZmlnKTsKPiA+ICsJCWlmIChjcnRjX3N0YXRlLT5iYXNlLmFjdGl2ZSkgewo+ID4g KwkJCWludGVsX21vZGVfZnJvbV9waXBlX2NvbmZpZygmY3J0Yy0+YmFzZS5tb2RlLCBjcnRjX3N0 YXRlKTsKPiA+ICsJCQlpbnRlbF9tb2RlX2Zyb21fcGlwZV9jb25maWcoJmNydGNfc3RhdGUtPmJh c2UuYWRqdXN0ZWRfbW9kZSwgY3J0Y19zdGF0ZSk7Cj4gPiAgCQkJV0FSTl9PTihkcm1fYXRvbWlj X3NldF9tb2RlX2Zvcl9jcnRjKGNydGMtPmJhc2Uuc3RhdGUsICZjcnRjLT5iYXNlLm1vZGUpKTsK PiA+ICAKPiA+ICAJCQkvKgo+ID4gQEAgLTE3MTQ2LDE3ICsxNzE1NiwxNyBAQCBzdGF0aWMgdm9p ZCBpbnRlbF9tb2Rlc2V0X3JlYWRvdXRfaHdfc3RhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRldikK PiA+ICAJCQkgKiBtb2RlIGNoYW5nZSwgd2hpY2ggbWVhbnMgaXQncyBzYWZlIHRvIGRvIGEgZnVs bAo+ID4gIAkJCSAqIHJlY2FsY3VsYXRpb24uCj4gPiAgCQkJICovCj4gPiAtCQkJY3J0Yy0+YmFz ZS5zdGF0ZS0+bW9kZS5wcml2YXRlX2ZsYWdzID0gSTkxNV9NT0RFX0ZMQUdfSU5IRVJJVEVEOwo+ ID4gKwkJCWNydGNfc3RhdGUtPmJhc2UubW9kZS5wcml2YXRlX2ZsYWdzID0gSTkxNV9NT0RFX0ZM QUdfSU5IRVJJVEVEOwo+ID4gIAo+ID4gIAkJCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDkg fHwgSVNfQlJPQURXRUxMKGRldl9wcml2KSkKPiA+IC0JCQkJcGl4Y2xrID0gaWxrX3BpcGVfcGl4 ZWxfcmF0ZShjcnRjLT5jb25maWcpOwo+ID4gKwkJCQlwaXhjbGsgPSBpbGtfcGlwZV9waXhlbF9y YXRlKGNydGNfc3RhdGUpOwo+ID4gIAkJCWVsc2UgaWYgKElTX1ZBTExFWVZJRVcoZGV2X3ByaXYp IHx8IElTX0NIRVJSWVZJRVcoZGV2X3ByaXYpKQo+ID4gLQkJCQlwaXhjbGsgPSBjcnRjLT5jb25m aWctPmJhc2UuYWRqdXN0ZWRfbW9kZS5jcnRjX2Nsb2NrOwo+ID4gKwkJCQlwaXhjbGsgPSBjcnRj X3N0YXRlLT5iYXNlLmFkanVzdGVkX21vZGUuY3J0Y19jbG9jazsKPiA+ICAJCQllbHNlCj4gPiAg CQkJCVdBUk5fT04oZGV2X3ByaXYtPmRpc3BsYXkubW9kZXNldF9jYWxjX2NkY2xrKTsKPiA+ICAK PiA+ICAJCQkvKiBwaXhlbCByYXRlIG11c3RuJ3QgZXhjZWVkIDk1JSBvZiBjZGNsayB3aXRoIElQ UyBvbiBCRFcgKi8KPiA+IC0JCQlpZiAoSVNfQlJPQURXRUxMKGRldl9wcml2KSAmJiBjcnRjLT5j b25maWctPmlwc19lbmFibGVkKQo+ID4gKwkJCWlmIChJU19CUk9BRFdFTEwoZGV2X3ByaXYpICYm IGNydGNfc3RhdGUtPmlwc19lbmFibGVkKQo+ID4gIAkJCQlwaXhjbGsgPSBESVZfUk9VTkRfVVAo cGl4Y2xrICogMTAwLCA5NSk7Cj4gPiAgCj4gPiAgCQkJZHJtX2NhbGNfdGltZXN0YW1waW5nX2Nv bnN0YW50cygmY3J0Yy0+YmFzZSwgJmNydGMtPmJhc2UuaHdtb2RlKTsKPiA+IEBAIC0xNzE2NSw3 ICsxNzE3NSw3IEBAIHN0YXRpYyB2b2lkIGludGVsX21vZGVzZXRfcmVhZG91dF9od19zdGF0ZShz dHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ID4gIAo+ID4gIAkJZGV2X3ByaXYtPm1pbl9waXhjbGtb Y3J0Yy0+cGlwZV0gPSBwaXhjbGs7Cj4gPiAgCj4gPiAtCQlpbnRlbF9waXBlX2NvbmZpZ19zYW5p dHlfY2hlY2soZGV2X3ByaXYsIGNydGMtPmNvbmZpZyk7Cj4gPiArCQlpbnRlbF9waXBlX2NvbmZp Z19zYW5pdHlfY2hlY2soZGV2X3ByaXYsIGNydGNfc3RhdGUpOwo+ID4gIAl9Cj4gPiAgfQo+ID4g IAo+ID4gLS0gCj4gPiAyLjEwLjIKPiA+IAo+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KPiA+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+IEludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4gCj4gLS0gCj4gRGFuaWVsIFZldHRlcgo+ IFNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgo+IGh0dHA6Ly9ibG9nLmZmd2xs LmNoCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK