From: Shaohua Li <shli@kernel.org>
To: Geliang Tang <geliangtang@gmail.com>
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] md/bitmap: use i_blocksize()
Date: Sat, 21 Jan 2017 10:13:07 -0800 [thread overview]
Message-ID: <20170121181307.mbvoe45ca3d7sufv@kernel.org> (raw)
In-Reply-To: <2e7ac27f6ca34bfa01f3b6906fdf409c348e9187.1484895660.git.geliangtang@gmail.com>
On Fri, Jan 20, 2017 at 10:29:52PM +0800, Geliang Tang wrote:
> Since i_blocksize() helper has been defined in fs.h, use it instead
> of open-coding.
which tree is this patch applied to? I can't find it in Linus's tree
> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
> ---
> drivers/md/bitmap.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
> index 9fb2cca..30b1b89 100644
> --- a/drivers/md/bitmap.c
> +++ b/drivers/md/bitmap.c
> @@ -367,7 +367,7 @@ static int read_page(struct file *file, unsigned long index,
> pr_debug("read bitmap file (%dB @ %llu)\n", (int)PAGE_SIZE,
> (unsigned long long)index << PAGE_SHIFT);
>
> - bh = alloc_page_buffers(page, 1<<inode->i_blkbits, 0);
> + bh = alloc_page_buffers(page, i_blocksize(inode), 0);
> if (!bh) {
> ret = -ENOMEM;
> goto out;
> @@ -385,10 +385,10 @@ static int read_page(struct file *file, unsigned long index,
> goto out;
> }
> bh->b_bdev = inode->i_sb->s_bdev;
> - if (count < (1<<inode->i_blkbits))
> + if (count < i_blocksize(inode))
> count = 0;
> else
> - count -= (1<<inode->i_blkbits);
> + count -= i_blocksize(inode);
>
> bh->b_end_io = end_bitmap_write;
> bh->b_private = bitmap;
> --
> 2.9.3
>
next prev parent reply other threads:[~2017-01-21 18:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 14:29 [PATCH] ext4: use i_blocksize() Geliang Tang
2017-01-20 14:29 ` [PATCH] fs/buffer: " Geliang Tang
2017-01-20 14:29 ` [PATCH] isofs: " Geliang Tang
2017-01-20 14:29 ` [PATCH] md/bitmap: " Geliang Tang
2017-01-20 15:00 ` Coly Li
2017-01-21 18:13 ` Shaohua Li [this message]
2017-01-22 1:50 ` Geliang Tang
2017-05-02 14:33 ` Geliang Tang
2017-01-20 14:29 ` [PATCH] staging: lustre: " Geliang Tang
2017-01-20 23:34 ` [lustre-devel] " James Simmons
2017-01-20 23:34 ` James Simmons
2017-01-20 14:29 ` [PATCH] truncate: " Geliang Tang
2017-01-20 14:29 ` Geliang Tang
2017-01-20 17:39 ` Ross Zwisler
2017-01-20 17:39 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170121181307.mbvoe45ca3d7sufv@kernel.org \
--to=shli@kernel.org \
--cc=geliangtang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.