From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Andrew Boyer <andrew.boyer-8PEkshWhKlo@public.gmane.org>,
Dennis Dalessandro
<dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Jonathan Toppins
<jtoppins-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Alex Estrin <alex.estrin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v3 37/37] IB/rxe, IB/rdmavt: Use dma_virt_ops instead of duplicating it
Date: Sun, 22 Jan 2017 16:11:41 +0200 [thread overview]
Message-ID: <20170122141141.GI28570@mtr-leonro.local> (raw)
In-Reply-To: <20170120210437.26389-38-bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 2248 bytes --]
On Fri, Jan 20, 2017 at 01:04:37PM -0800, Bart Van Assche wrote:
> Make the rxe and rdmavt drivers use dma_virt_ops. Update the
> comments that refer to the source files removed by this patch.
> Remove struct ib_dma_mapping_ops. Remove ib_device.dma_ops.
>
> Signed-off-by: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
> Cc: Andrew Boyer <andrew.boyer-8PEkshWhKlo@public.gmane.org>
> Cc: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Cc: Jonathan Toppins <jtoppins-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Cc: Alex Estrin <alex.estrin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Cc: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
> drivers/infiniband/sw/rdmavt/Kconfig | 1 +
> drivers/infiniband/sw/rdmavt/Makefile | 2 +-
> drivers/infiniband/sw/rdmavt/dma.c | 198 ----------------------------------
> drivers/infiniband/sw/rdmavt/dma.h | 53 ---------
> drivers/infiniband/sw/rdmavt/mr.c | 8 +-
> drivers/infiniband/sw/rdmavt/vt.c | 4 +-
> drivers/infiniband/sw/rdmavt/vt.h | 1 -
> drivers/infiniband/sw/rxe/Kconfig | 1 +
> drivers/infiniband/sw/rxe/Makefile | 1 -
> drivers/infiniband/sw/rxe/rxe_dma.c | 183 -------------------------------
> drivers/infiniband/sw/rxe/rxe_loc.h | 2 -
> drivers/infiniband/sw/rxe/rxe_verbs.c | 3 +-
> include/rdma/ib_verbs.h | 103 ++----------------
> 13 files changed, 18 insertions(+), 542 deletions(-)
> delete mode 100644 drivers/infiniband/sw/rdmavt/dma.c
> delete mode 100644 drivers/infiniband/sw/rdmavt/dma.h
> delete mode 100644 drivers/infiniband/sw/rxe/rxe_dma.c
>
> diff --git a/drivers/infiniband/sw/rdmavt/Kconfig b/drivers/infiniband/sw/rdmavt/Kconfig
> index 1da8d01a6855..fdd001ce13d8 100644
> --- a/drivers/infiniband/sw/rdmavt/Kconfig
> +++ b/drivers/infiniband/sw/rdmavt/Kconfig
> @@ -1,5 +1,6 @@
> config INFINIBAND_RDMAVT
> tristate "RDMA verbs transport library"
> depends on 64BIT
> + select DMA_VIRT_OPS
Bart,
Small question, is it an easy way to select this option
for whole INFINIBAND instead of doing for every driver?
Besides that,
Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-01-22 14:11 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 21:04 [PATCH v3 00/37] IB: Optimize DMA mapping Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 02/37] treewide: Move dma_ops from struct dev_archdata into struct device Bart Van Assche
2017-01-20 21:04 ` Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 03/37] treewide: Consolidate set_dma_ops() implementations Bart Van Assche
2017-01-20 21:04 ` Bart Van Assche
2017-01-20 21:04 ` Bart Van Assche
2017-01-20 21:04 ` Bart Van Assche
2017-01-30 13:58 ` Russell King - ARM Linux
2017-01-30 13:58 ` Russell King - ARM Linux
[not found] ` <20170120210437.26389-1-bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-01-20 21:04 ` [PATCH v3 01/37] treewide: Constify most dma_map_ops structures Bart Van Assche
2017-01-20 21:04 ` Bart Van Assche
2017-01-20 21:04 ` Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 04/37] treewide: Consolidate get_dma_ops() implementations Bart Van Assche
2017-01-20 21:04 ` Bart Van Assche
2017-01-20 21:04 ` Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 05/37] lib/dma-noop: Clarify a comment Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 06/37] lib/dma-noop: Only build dma_noop_ops for s390 and m32r Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 07/37] lib/dma-virt: Add dma_virt_ops Bart Van Assche
[not found] ` <20170120210437.26389-8-bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-01-23 16:03 ` Joerg Roedel
[not found] ` <20170123160341.GM9529-l3A5Bk7waGM@public.gmane.org>
2017-01-23 16:12 ` Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 08/37] IB/core: Remove ib_dma_*map_single_attrs() Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 09/37] RDS: IB: Remove an unused structure member Bart Van Assche
2017-01-20 21:04 ` Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 10/37] IB/core: Change the type of an ib_dma_alloc_coherent() argument Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 11/37] IB/hf1: Remove DMA mapping code Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 12/37] IB/qib: " Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 13/37] IB/core: Initialize ib_device.dev.parent earlier Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 14/37] IB/core: Use dev.parent instead of dma_device Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 15/37] IB/cxgb3: Set " Bart Van Assche
[not found] ` <20170120210437.26389-16-bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-01-20 21:27 ` Steve Wise
2017-01-20 21:04 ` [PATCH v3 16/37] IB/cxgb4: " Bart Van Assche
[not found] ` <20170120210437.26389-17-bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-01-20 21:27 ` Steve Wise
2017-01-20 21:04 ` [PATCH v3 17/37] IB/hfi1: Switch from dma_device to dev.parent Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 18/37] IB/hns: " Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 19/37] IB/i40iw: Remove a superfluous assignment statement Bart Van Assche
[not found] ` <20170120210437.26389-20-bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-01-21 14:18 ` Shiraz Saleem
2017-01-20 21:04 ` [PATCH v3 20/37] IB/mlx4: Switch from dma_device to dev.parent Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 21/37] IB/mlx5: " Bart Van Assche
[not found] ` <20170120210437.26389-22-bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-01-22 14:15 ` Leon Romanovsky
2017-01-20 21:04 ` [PATCH v3 22/37] IB/mthca: " Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 23/37] IB/nes: Remove a superfluous assignment statement Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 24/37] IB/ocrdma: Switch from dma_device to dev.parent Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 25/37] IB/qedr: " Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 26/37] IB/qib: " Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 27/37] IB/usnic: " Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 28/37] IB/vmw_pvrdma: " Bart Van Assche
[not found] ` <20170120210437.26389-29-bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-01-20 21:54 ` Adit Ranadive
2017-01-20 21:04 ` [PATCH v3 29/37] IB/rxe: " Bart Van Assche
[not found] ` <20170120210437.26389-30-bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-01-26 21:06 ` Boyer, Andrew
[not found] ` <D4AFCE43.A031%Andrew.Boyer-mb1K0bWo544@public.gmane.org>
2017-01-27 22:14 ` Bart Van Assche
[not found] ` <1485555269.13218.10.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-02-14 16:47 ` Doug Ledford
2017-01-20 21:04 ` [PATCH v3 30/37] IB/IPoIB: " Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 31/37] IB/iser: " Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 32/37] IB/srp: " Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 33/37] IB/srpt: Modify a debug statement Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 34/37] RDS: net: Switch from dma_device to dev.parent Bart Van Assche
[not found] ` <20170120210437.26389-35-bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-01-20 23:24 ` Santosh Shilimkar
2017-01-20 21:04 ` [PATCH v3 35/37] nvme-rdma: " Bart Van Assche
[not found] ` <20170120210437.26389-36-bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-01-22 16:08 ` Sagi Grimberg
2017-01-20 21:04 ` [PATCH v3 36/37] IB/core: Remove ib_device.dma_device Bart Van Assche
2017-01-20 21:04 ` [PATCH v3 37/37] IB/rxe, IB/rdmavt: Use dma_virt_ops instead of duplicating it Bart Van Assche
[not found] ` <20170120210437.26389-38-bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-01-22 14:11 ` Leon Romanovsky [this message]
[not found] ` <20170122141141.GI28570-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-01-22 15:51 ` Bart Van Assche
2017-01-26 21:00 ` Boyer, Andrew
2017-01-20 21:57 ` [PATCH v3 00/37] IB: Optimize DMA mapping Laurence Oberman
[not found] ` <1671405275.19009584.1484949453215.JavaMail.zimbra-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-01-20 22:18 ` Bart Van Assche
[not found] ` <1484950725.2665.10.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-01-20 22:23 ` Laurence Oberman
2017-01-24 17:38 ` Doug Ledford
[not found] ` <1485279487.43764.38.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-01-24 17:43 ` Bart Van Assche
[not found] ` <1485279791.2715.3.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-01-24 17:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170122141141.GI28570@mtr-leonro.local \
--to=leonro-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=alex.estrin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=andrew.boyer-8PEkshWhKlo@public.gmane.org \
--cc=bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org \
--cc=dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jtoppins-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.