From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v2] Input: silead - Add support for setting resolution based on dmi data Date: Sun, 22 Jan 2017 14:23:24 -0800 Message-ID: <20170122222324.GC31009@dtor-ws> References: <20170102105538.4009-1-hdegoede@redhat.com> <20170121190413.GB36944@dtor-ws> <00a665ed-6930-f44f-a170-498193df2963@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pg0-f65.google.com ([74.125.83.65]:36109 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750715AbdAVWX2 (ORCPT ); Sun, 22 Jan 2017 17:23:28 -0500 Received: by mail-pg0-f65.google.com with SMTP id 75so11947423pgf.3 for ; Sun, 22 Jan 2017 14:23:27 -0800 (PST) Content-Disposition: inline In-Reply-To: <00a665ed-6930-f44f-a170-498193df2963@redhat.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Hans de Goede Cc: "russianneuromancer @ ya . ru" , Gregor Riepl , linux-input@vger.kernel.org On Sun, Jan 22, 2017 at 12:03:07PM +0100, Hans de Goede wrote: > Hi, > > On 21-01-17 20:04, Dmitry Torokhov wrote: > >Hi Hans, > > > >On Mon, Jan 02, 2017 at 11:55:38AM +0100, Hans de Goede wrote: > >>On ACPI based tablets, the ACPI touchscreen node only contains info on > >>the gpio and the irq, and is missing any info on the axis. This info is > >>expected to be built into the tablet model specific version of the driver > >>shipped with the os-image for the device. > >> > >>Add support for getting the missing info from a table built into the > >>driver, using dmi data to identify which entry of the table to use and > >>add info for the CUBE iwork8 Air and Jumper EZpad mini3 tablets on which > >>this code was tested / developed. > >> > >>BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=187531 > >>Signed-off-by: Hans de Goede > >>--- > >>Changes in v2: > >>-Put the dmi code in a separate silead_dmi.c file > >>-Use device_add_properties to add the info > > > >This leaks data (device_add_properties() does deep copy of properties) > >you unbind and rebind the driver. > > > >Also I would prefer this all be kept in the swamp that is platform > >drivers and I believe we have enough infrastructure to do just that. > >Could you please tell me if the following version of the patch works on > >your devices? > > I had to drop the unregistering of the bus-notifier, as the i2c controller > driver may be a module (and in my case is as I'm testing with a Fedora > distro kernel based .config) so the device may not get registered > till after late_init. Ah, indeed. I was bouncing between ACPI bus notifier and i2c one and with i2c we indeed need the notifier to stick around. Thanks. -- Dmitry