From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH v3] vfio error recovery: kernel support Date: Mon, 23 Jan 2017 01:01:12 +0200 Message-ID: <20170123010102-mutt-send-email-mst@kernel.org> References: <1485070594-27713-1-git-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Jason Wang Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org T24gU3VuLCBKYW4gMjIsIDIwMTcgYXQgMDQ6MDE6MjhQTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPiAKPiAKPiBPbiAyMDE35bm0MDHmnIgyMuaXpSAxNTozOCwgTWljaGFlbCBTLiBUc2lya2lu IHdyb3RlOgo+ID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvdmlydGlvX2NvbmZpZy5oIGIv aW5jbHVkZS9saW51eC92aXJ0aW9fY29uZmlnLmgKPiA+IGluZGV4IDI2YzE1NWIuLjZiMGY0MTYg MTAwNjQ0Cj4gPiAtLS0gYS9pbmNsdWRlL2xpbnV4L3ZpcnRpb19jb25maWcuaAo+ID4gKysrIGIv aW5jbHVkZS9saW51eC92aXJ0aW9fY29uZmlnLmgKPiA+IEBAIC0xNTksNyArMTU5LDE3IEBAIHN0 YXRpYyBpbmxpbmUgYm9vbCB2aXJ0aW9faGFzX2lvbW11X3F1aXJrKGNvbnN0IHN0cnVjdCB2aXJ0 aW9fZGV2aWNlICp2ZGV2KQo+ID4gICAJICogTm90ZSB0aGUgcmV2ZXJzZSBwb2xhcml0eSBvZiB0 aGUgcXVpcmsgZmVhdHVyZSAoY29tcGFyZWQgdG8gbW9zdAo+ID4gICAJICogb3RoZXIgZmVhdHVy ZXMpLCB0aGlzIGlzIGZvciBjb21wYXRpYmlsaXR5IHdpdGggbGVnYWN5IHN5c3RlbXMuCj4gPiAg IAkgKi8KPiA+IC0JcmV0dXJuICF2aXJ0aW9faGFzX2ZlYXR1cmUodmRldiwgVklSVElPX0ZfSU9N TVVfUExBVEZPUk0pOwo+ID4gKwlpZiAodmlydGlvX2hhc19mZWF0dXJlKHZkZXYsIFZJUlRJT19G X0lPTU1VX1BMQVRGT1JNKSkKPiA+ICsJCXJldHVybiBmYWxzZTsKPiA+ICsKPiA+ICsJLyoKPiA+ ICsJICogZmFzdGJvb3QgZW11bGF0b3IgZm9yIEFSTSBwdXRzIHZpcnRpbyBkZXZpY2VzIGJlaGlu ZCBhbiBTTU1VCj4gPiArCSAqIGFuZCBuZXZlciBieXBhc3NlcyBpdCBmb3IgbGVnYWN5IGRldmlj ZXMuCj4gPiArCSAqLwo+ID4gKwlpZiAoSVNfRU5BQkxFRChDT05GSUdfQVJNKSB8fCBJU19FTkFC TEVEKENPTkZJR19BUk02NCkpCj4gPiArCQlyZXR1cm4gdmlydGlvX2hhc19mZWF0dXJlKHZkZXYs IFZJUlRJT19GX1ZFUlNJT05fMSk7Cj4gPiArCj4gPiArCXJldHVybiB0cnVlOwo+ID4gICB9Cj4g Cj4gSGkgTWljaGFlbDoKPiAKPiBUaGlzIHBhcnQgb2YgY29kZXMgc2VlbXMgdW5yZWxhdGVkLgo+ IAo+IFRoYW5rcwoKT2YgY291cnNlIGl0IGlzLCB0aGFua3MhCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApW aXJ0dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxp bnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750797AbdAVXBP (ORCPT ); Sun, 22 Jan 2017 18:01:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35266 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750704AbdAVXBO (ORCPT ); Sun, 22 Jan 2017 18:01:14 -0500 Date: Mon, 23 Jan 2017 01:01:12 +0200 From: "Michael S. Tsirkin" To: Jason Wang Cc: linux-kernel@vger.kernel.org, Alex Williamson , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v3] vfio error recovery: kernel support Message-ID: <20170123010102-mutt-send-email-mst@kernel.org> References: <1485070594-27713-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Sun, 22 Jan 2017 23:01:14 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 22, 2017 at 04:01:28PM +0800, Jason Wang wrote: > > > On 2017年01月22日 15:38, Michael S. Tsirkin wrote: > > diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h > > index 26c155b..6b0f416 100644 > > --- a/include/linux/virtio_config.h > > +++ b/include/linux/virtio_config.h > > @@ -159,7 +159,17 @@ static inline bool virtio_has_iommu_quirk(const struct virtio_device *vdev) > > * Note the reverse polarity of the quirk feature (compared to most > > * other features), this is for compatibility with legacy systems. > > */ > > - return !virtio_has_feature(vdev, VIRTIO_F_IOMMU_PLATFORM); > > + if (virtio_has_feature(vdev, VIRTIO_F_IOMMU_PLATFORM)) > > + return false; > > + > > + /* > > + * fastboot emulator for ARM puts virtio devices behind an SMMU > > + * and never bypasses it for legacy devices. > > + */ > > + if (IS_ENABLED(CONFIG_ARM) || IS_ENABLED(CONFIG_ARM64)) > > + return virtio_has_feature(vdev, VIRTIO_F_VERSION_1); > > + > > + return true; > > } > > Hi Michael: > > This part of codes seems unrelated. > > Thanks Of course it is, thanks!