All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Jason Gerecke <killertofu@gmail.com>
Cc: Jiri Kosina <jikos@kernel.org>, Ping Cheng <pinglinux@gmail.com>,
	Aaron Skomra <skomra@gmail.com>,
	linux-kernel@vger.kernel.org,
	Linux Input <linux-input@vger.kernel.org>
Subject: Re: [PATCH 0/4] HID: wacom: fixes for next
Date: Mon, 23 Jan 2017 09:02:40 +0100	[thread overview]
Message-ID: <20170123080240.GA8653@mail.corp.redhat.com> (raw)
In-Reply-To: <CANRwn3QHsoURBnpybX4Bn1UAMif13yqo16NEg1JFqfz4GD=3dA@mail.gmail.com>

On Jan 20 2017 or thereabouts, Jason Gerecke wrote:
> Patches 1/3 look reasonable to me, though I've not run into the bugs
> they aim to fix. For those:
> 
> Acked-by: Jason Gerecke <jason.gerecke@wacom.com>
> 
> As for patch 4, I have some additional reservations about hiding the
> message... We can discuss that further in its thread.
> 

Yeah, I am fine dropping patch 4. Thanks for the review/tests Jason!

Cheers,
Benjamin

> Jason
> ---
> Now instead of four in the eights place /
> you’ve got three, ‘Cause you added one  /
> (That is to say, eight) to the two,     /
> But you can’t take seven from three,    /
> So you look at the sixty-fours....
> 
> 
> 
> On Fri, Jan 20, 2017 at 7:20 AM, Benjamin Tissoires
> <benjamin.tissoires@redhat.com> wrote:
> > Hi,
> >
> > well, these are non critical but nonetheless interesting fixes for
> > Wacom I was working on last week. I was waiting for the current v4.10
> > fix to be sent by Jason before pushing those out.
> >
> > Cheers,
> > Benjamin
> >
> > Benjamin Tissoires (4):
> >   HID: wacom: release the resources before leaving despite devm
> >   HID: wacom: remove warning while disconnecting devices
> >   HID: wacom: do not attempt to switch mode while in probe
> >   HID: wacom: do not shout an error on LED control
> >
> >  drivers/hid/wacom.h     |  1 +
> >  drivers/hid/wacom_sys.c | 42 ++++++++++++++++++++++++++++++------------
> >  2 files changed, 31 insertions(+), 12 deletions(-)
> >
> > --
> > 2.9.3
> >

  reply	other threads:[~2017-01-23  8:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-20 15:20 [PATCH 0/4] HID: wacom: fixes for next Benjamin Tissoires
2017-01-20 15:20 ` [PATCH 1/4] HID: wacom: release the resources before leaving despite devm Benjamin Tissoires
2017-01-20 15:20 ` [PATCH 2/4] HID: wacom: remove warning while disconnecting devices Benjamin Tissoires
2017-01-20 15:20 ` [PATCH 3/4] HID: wacom: do not attempt to switch mode while in probe Benjamin Tissoires
2017-01-20 15:20 ` [PATCH 4/4] HID: wacom: do not shout an error on LED control Benjamin Tissoires
2017-01-21  2:31   ` Jason Gerecke
2017-01-21  2:35 ` [PATCH 0/4] HID: wacom: fixes for next Jason Gerecke
2017-01-23  8:02   ` Benjamin Tissoires [this message]
2017-01-23 10:01     ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170123080240.GA8653@mail.corp.redhat.com \
    --to=benjamin.tissoires@redhat.com \
    --cc=jikos@kernel.org \
    --cc=killertofu@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pinglinux@gmail.com \
    --cc=skomra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.