From: Olivier Matz <olivier.matz@6wind.com>
To: Sergey Vyazmitinov <s.vyazmitinov@brain4net.com>
Cc: konstantin.ananyev@intel.com, stephen@networkplumber.org,
yuanhan.liu@linux.intel.com, ferruh.yigit@intel.com,
dev@dpdk.org, mirqus@gmail.com
Subject: Re: [PATCH v6 1/2] kni: add bulk function to free mbufs
Date: Mon, 23 Jan 2017 14:19:37 +0100 [thread overview]
Message-ID: <20170123141937.75390eef@platinum> (raw)
In-Reply-To: <20170123135947.0e5cbe83@platinum>
Hi,
[resent and updated, previous mail was sent from the wrong address]
On Mon, 23 Jan 2017 13:59:47 +0100, Olivier Matz
<olivier.matz@6wind.com> wrote:
> > + * @param mbufs
> > + * The packets mbufs array to be freed.
> > + * @param n
> > + * Number of packets.
> > + */
> > +static inline void rte_pktmbuf_free_bulk(struct rte_mbuf **mbufs,
> > + unsigned int n)
>
> I suggest we could use mbuf instead of pktmbuf in the function name.
> It's a bit shorter, and the function would also apply on ctrlmbuf.
Sorry, please ignore this one. It's more consistent to have a
rte_pktmbuf_free and rte_pktmbuf_free_bulk having the same prefix.
Also a small comment on the title: it should be "mbuf:", not "kni:".
In the other patch, the uppercase in "Use" could also be changed to
lowercase (seen with ./devtools/check-git-log.sh).
Thanks,
Olivier
next prev parent reply other threads:[~2017-01-23 13:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 4:46 [PATCH v6 0/2] kni: use bulk functions to allocate and free mbufs Sergey Vyazmitinov
2017-01-19 4:46 ` [PATCH v6 1/2] kni: add bulk function to " Sergey Vyazmitinov
2017-01-23 12:59 ` Olivier Matz
2017-01-23 13:19 ` Olivier Matz [this message]
2017-01-19 4:46 ` [PATCH v6 2/2] kni: Use bulk functions to allocate and " Sergey Vyazmitinov
2017-01-25 20:10 ` Ferruh Yigit
2017-01-25 19:04 ` [PATCH v6 0/2] kni: use " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170123141937.75390eef@platinum \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=mirqus@gmail.com \
--cc=s.vyazmitinov@brain4net.com \
--cc=stephen@networkplumber.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.