From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH v2] drm/exynos: use atomic helper commit Date: Mon, 23 Jan 2017 11:20:42 -0500 Message-ID: <20170123162041.GA22897@trickycodes.roam.corp.google.com> References: <1484821118-10479-1-git-send-email-inki.dae@samsung.com> <5880B5E8.4000309@math.uni-bielefeld.de> <5881874A.5050506@samsung.com> <58820B33.8050107@math.uni-bielefeld.de> <5885C63B.7060606@samsung.com> <5885FABB.20909@math.uni-bielefeld.de> <20170123145506.GA17868@trickycodes.roam.corp.google.com> <588628F4.50808@math.uni-bielefeld.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from mail-qt0-f174.google.com ([209.85.216.174]:36488 "EHLO mail-qt0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750821AbdAWQUp (ORCPT ); Mon, 23 Jan 2017 11:20:45 -0500 Received: by mail-qt0-f174.google.com with SMTP id k15so132631329qtg.3 for ; Mon, 23 Jan 2017 08:20:44 -0800 (PST) Content-Disposition: inline In-Reply-To: <588628F4.50808@math.uni-bielefeld.de> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Tobias Jakobi Cc: linux-samsung-soc@vger.kernel.org, dri-devel@lists.freedesktop.org On Mon, Jan 23, 2017 at 05:01:56PM +0100, Tobias Jakobi wrote: > Sean Paul wrote: > > > > > >>>>> As of now, I don't see any case. even without Maarten's patch set, it works well - actually, I had a test with atomic test app more than 10 hours.. > >>>> Can you provide this test application? In particular I'm asking this > >>>> because libdrm currently doesn't provide any tests using the atomic API. > >>>> So this application might be of interest also for other people. > >>> > >>> Below is the app I tested. Know that this application is from chromiumOS tree and I just fixed some parts for internal test. > >>> https://review.tizen.org/git/?p=atform/upstream/libdrm.git;a=commitdiff;h�3bd95f2c5a9b4b69062a3ff008947054b94f55 > >> Thanks, any chance this is going to be submitted upstream? > >> > > > > Probably not in its current form. I just wrote it to quickly test out > > some stuff we didn't yet support in CrOS. I don't really think it's fit > > for inclusion upstream. > Thanks for the clarification! Just voicing my interest here to have > something like this upstream. I mean with atomic now being mandatory for > new DRM kernel drivers and all... :-) Agreed that tests are important, I'm just hesitant to sling my spaghetti code around too widely :) The igt suite should have you covered for basic testing and more. CrOS also has a bsdrm test suite that may or may not become atomic-aware in the future. Both are better options that my atomictest, IMO. Sean > > - Tobias > > > > > > Sean > > > > > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS