From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm: don't link DP aux i2c adapter to the hardware device node Date: Mon, 23 Jan 2017 17:33:47 +0100 Message-ID: <20170123163347.GC2043@ulmo.ba.sec> References: <20170113173630.22138-1-l.stach@pengutronix.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1094503886==" Return-path: Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id DE24D6E095 for ; Mon, 23 Jan 2017 16:33:50 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id r144so27606505wme.0 for ; Mon, 23 Jan 2017 08:33:50 -0800 (PST) In-Reply-To: <20170113173630.22138-1-l.stach@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Lucas Stach Cc: Daniel Vetter , kernel@pengutronix.de, dri-devel@lists.freedesktop.org, patchwork-lst@pengutronix.de List-Id: dri-devel@lists.freedesktop.org --===============1094503886== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DIOMP1UsTsWJauNi" Content-Disposition: inline --DIOMP1UsTsWJauNi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jan 13, 2017 at 06:36:30PM +0100, Lucas Stach wrote: > The i2c adapter on DP AUX is purely a software construct. Linking > it to the device node of the parent device is wrong, as it leads to > 2 devices sharing the same device node, which is bad practice, as Who says that two devices can't share the same device node? It's done all the time. > well as the i2c trying to populate children of the i2c adapter by > looking at the child device nodes of the parent device. A set of patches landed in v4.9 to work around this issue in a better way. See: 98b00488459e dt-bindings: i2c: Add support for 'i2c-bus' subnode 7e4c224abfe8 i2c: core: Add support for 'i2c-bus' subnode Thierry --DIOMP1UsTsWJauNi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAliGMGsACgkQ3SOs138+ s6Gdhg//a/ucAJB+E8X5yK4qWZ393L4CoOJ7HnAAOEioXFpykJAcQsl17UjxDz4f f8YyLiIUwN/tQBVTJA52cmoOM2wup5MFPgg9K7hisBmmjVT5EYajDpHCUkmlxY/r R+L2awd8C9+qbnKnIpnzN1x6pd24upD7d9hTQoWEhwqomgGTps2h4DhAovSpJLZn 41eoJIfUpvEduTqALrFydjPrGdrSvwkhKAd5XggOE4X7TLmjINMqlzHrzHauR76J le23SIyRVs/WgfHdljKIEXtodhgrnPNSp7qz+M0FFwnCLDGCLmIIodhhiunkm7qe waKOkgtQrm1Y5iIO68lNCKxEbq5jgb1ABFD8s0+utXmaDQ8smiofIAyBxpmViaMV QGKhvf7cIkaq2OY7Z7lm9yp/ios4RHnVbFNcgV6W060ujTCeWDBKDxS/IBS0B6hg BWAHsZnhFaQYj3nbPyI72iMUDDIPrLNMALduiJFqBs0gSjKdI8FbbX0Sm55J6uc2 jkNXyDv4VFMMF8vuRh4glFBUgfopEzL4z7ORMKwLYVSUcJXiRu3sTp85NF4RkEVn 6qP1rJaitOXhS5XJAKcYDfDcXreWpWYGmun9XUCRxXIL7xthVGjljZu0ISXWLsmm toRaI8oeuKT4/dPcC+gvCzDsD0GcPi2XnACQAOaz1CrLpT9v/hU= =5sCU -----END PGP SIGNATURE----- --DIOMP1UsTsWJauNi-- --===============1094503886== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1094503886==--