From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH v2 1/2] iommu/dma: Stop getting dma_32bit_pfn wrong Date: Mon, 23 Jan 2017 17:40:13 +0000 Message-ID: <20170123174012.GE28914@arm.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Robin Murphy Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org On Mon, Jan 16, 2017 at 01:24:54PM +0000, Robin Murphy wrote: > iommu_dma_init_domain() was originally written under the misconception > that dma_32bit_pfn represented some sort of size limit for IOVA domains. > Since the truth is almost the exact opposite of that, rework the logic > and comments to reflect its real purpose of optimising lookups when > allocating from a subset of the available 64-bit space. > > Signed-off-by: Robin Murphy > --- > > Sending this as a v2 since both patches have been seen before, and #1 is > ever so slightly tweaked. #2 applies on top of Eric's MSI series, since > that seems ready to go now - there is a trivial merge conflict otherwise > around the extra argument in the __alloc_iova() call. > > Robin. > > drivers/iommu/dma-iommu.c | 23 ++++++++++++++++++----- > 1 file changed, 18 insertions(+), 5 deletions(-) Tested-by: Will Deacon Will From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Mon, 23 Jan 2017 17:40:13 +0000 Subject: [PATCH v2 1/2] iommu/dma: Stop getting dma_32bit_pfn wrong In-Reply-To: References: Message-ID: <20170123174012.GE28914@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jan 16, 2017 at 01:24:54PM +0000, Robin Murphy wrote: > iommu_dma_init_domain() was originally written under the misconception > that dma_32bit_pfn represented some sort of size limit for IOVA domains. > Since the truth is almost the exact opposite of that, rework the logic > and comments to reflect its real purpose of optimising lookups when > allocating from a subset of the available 64-bit space. > > Signed-off-by: Robin Murphy > --- > > Sending this as a v2 since both patches have been seen before, and #1 is > ever so slightly tweaked. #2 applies on top of Eric's MSI series, since > that seems ready to go now - there is a trivial merge conflict otherwise > around the extra argument in the __alloc_iova() call. > > Robin. > > drivers/iommu/dma-iommu.c | 23 ++++++++++++++++++----- > 1 file changed, 18 insertions(+), 5 deletions(-) Tested-by: Will Deacon Will