Re: [Intel-gfx] [PATCH 0/4] Add automation support for DP Compliance (Rev 6)

[Manasi Navare <manasi.d.navare@intel.com>]

On Mon, Jan 23, 2017 at 09:05:02AM -0800, Manasi Navare wrote:
> On Sat, Jan 21, 2017 at 05:16:42PM +0200, Jani Nikula wrote:
> > On Sat, 21 Jan 2017, Manasi Navare <manasi.d.navare@intel.com> wrote:
> > > This patch series addresses all the review comments from the previous series:
> > > https://patchwork.freedesktop.org/series/18256/
> > 
> > It does not, and it frustrates me.
> > 
> > BR,
> > Jani.
> > 
> >

Jani,

I really appreciate all your feedback. I also agree that it is very important
that the patches are correct and improve the driver quality and that non eof the review
comments should be ignored even if it takes many review cycles.
As far as I know, I have addressed the review comments from previous round and answered
the questions/concerns that you had either in the M-L or in IRC.
May be answering them on IRC created some confusion and you thought that it was
unanswered. I will reply to all your review comments from previous round with what
I have chnaged to address it or why it wasnt changed. That way we can make sure that
none of them are getting ignored.
Hope this method works for you.

Regards
Manasi
 
> 
> Hi Jani,
> I have addressed the comments:
> 
> * Use link rate instead of link BW, validate the values before storing in the compliance structure
> and return NAK on invalid and read failures.
> * Corrected the definitins in drm_dp_helper.h
> 
> Could you please explain which of the comments were not addressed that made it so frustrating?
> It has been frustrating enough for me to be carrying this series of patches for a year almost
> knowing that it passes 100% compliance but still is not merged.
> 
> Regards
> Manasi
> 
>   
> > >
> > > On top of that it also adds a fix for CRC mismatches seen during
> > > 18bpp video pattern compliance testing. This is done by forcing dither
> > > on the pipe to be disabled if it is a 18bpp compliance test request.
> > >
> > > Manasi Navare (4):
> > >   drm/i915: Add support for DP link training compliance
> > >   drm/i915: Fixes to support DP Compliance EDID tests
> > >   drm: Add definitions for DP compliance Video pattern tests
> > >   drm/i915: Add support for DP Video pattern compliance tests
> > >
> > >  drivers/gpu/drm/i915/i915_debugfs.c  |  14 +++-
> > >  drivers/gpu/drm/i915/intel_display.c |   7 +-
> > >  drivers/gpu/drm/i915/intel_dp.c      | 134 +++++++++++++++++++++++++++++++++--
> > >  drivers/gpu/drm/i915/intel_dp_mst.c  |   7 +-
> > >  drivers/gpu/drm/i915/intel_drv.h     |  13 ++++
> > >  include/drm/drm_dp_helper.h          |  57 +++++++++++++++
> > >  6 files changed, 221 insertions(+), 11 deletions(-)
> > 
> > -- 
> > Jani Nikula, Intel Open Source Technology Center
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel