All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nils Holland <nholland-iI9p2NPcQ/rYtjvyW6yDsg@public.gmane.org>
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: [PATCH] drm/amdgpu: Fix error in amdgpu_bo_create_restricted()
Date: Tue, 24 Jan 2017 01:55:52 +0100	[thread overview]
Message-ID: <20170124005551.GA22069@tisys.org> (raw)

So I decided to fix this with the following follow-up patch. I hope
this is the right approach (vs. reverting the commit and instead using
a fixed v2 of the original patch).

From 41775d2c8a14873f522667a57b66cfbe119e28a4 Mon Sep 17 00:00:00 2001
From: Nils Holland <nholland@tisys.org>
Date: Tue, 24 Jan 2017 01:36:45 +0100
Subject: [PATCH] drm/amdgpu: Fix error in amdgpu_bo_create_restricted()

Remove mistakedly placed ; that prevents the code from compiling. No
functional change.

Signed-off-by: Nils Holland <nholland@tisys.org>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
index f71fe41c1c99..89d32131e3f5 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
@@ -377,7 +377,7 @@ int amdgpu_bo_create_restricted(struct amdgpu_device *adev,
 #warning Please enable CONFIG_MTRR and CONFIG_X86_PAT for better performance \
 	 thanks to write-combining
 
-	if (bo->flags & AMDGPU_GEM_CREATE_CPU_GTT_USWC;)
+	if (bo->flags & AMDGPU_GEM_CREATE_CPU_GTT_USWC)
 		DRM_INFO_ONCE("Please enable CONFIG_MTRR and CONFIG_X86_PAT for "
 			      "better performance thanks to write-combining\n");
 	bo->flags &= ~AMDGPU_GEM_CREATE_CPU_GTT_USWC;
-- 
2.11.0

Greetings
Nils
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

             reply	other threads:[~2017-01-24  0:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-24  0:55 Nils Holland [this message]
     [not found] ` <20170124005551.GA22069-iI9p2NPcQ/rYtjvyW6yDsg@public.gmane.org>
2017-01-24  1:35   ` [PATCH] drm/amdgpu: Fix error in amdgpu_bo_create_restricted() Michel Dänzer
     [not found]     ` <97f6e4c1-0851-51cc-c496-66c1e8f83c61-otUistvHUpPR7s880joybQ@public.gmane.org>
2017-01-24  7:43       ` Nils Holland
     [not found]         ` <20170124074340.GA9899-iI9p2NPcQ/rYtjvyW6yDsg@public.gmane.org>
2017-01-24  8:53           ` Christian König
     [not found]             ` <c42e3767-1f6e-a04f-956d-8112666c1dec-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2017-01-24  9:28               ` Nils Holland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170124005551.GA22069@tisys.org \
    --to=nholland-ii9p2npcq/rytjvyw6ydsg@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.