From: Wolfram Sang <wsa@the-dreams.de>
To: Stephen Boyd <stephen.boyd@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: Fix error print when address is invalid
Date: Tue, 24 Jan 2017 08:54:58 +0100 [thread overview]
Message-ID: <20170124075458.GA1432@katana> (raw)
In-Reply-To: <20170124022424.18212-1-stephen.boyd@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 703 bytes --]
On Mon, Jan 23, 2017 at 06:24:24PM -0800, Stephen Boyd wrote:
> When the address is invalid, we print out the address that's
> in info.addr, but that member of info hasn't been assigned yet.
> It's assigned in the line after we check the address. This causes
> the print to show something like
>
> i2c i2c-1: of_i2c: invalid addr=0 on ...
>
> when we want something like
>
> i2c i2c-1: of_i2c: invalid addr=0xaf on ...
>
> Just pass addr here, and update the print format to indicate hex
> as well.
>
> Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
Thanks, yet already fixed since v4.10-rc4 with 6f724fb3039522 ("i2c:
print correct device invalid address").
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2017-01-24 7:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 2:24 [PATCH] i2c: Fix error print when address is invalid Stephen Boyd
2017-01-24 7:54 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124075458.GA1432@katana \
--to=wsa@the-dreams.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stephen.boyd@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.