All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Kevin Hao <haokexin@gmail.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
	Yu-cheng Yu <yu-cheng.yu@intel.com>,
	fenghua.yu@intel.com, dvlasenk@redhat.com, peterz@infradead.org,
	oleg@redhat.com, linux-kernel@vger.kernel.org, brgerst@gmail.com,
	luto@kernel.org, bp@alien8.de, jpoimboe@redhat.com,
	hpa@zytor.com, quentin.casasnovas@oracle.com, tglx@linutronix.de,
	torvalds@linux-foundation.org, riel@redhat.com,
	linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/urgent] x86/fpu: Set the xcomp_bv when we fake up a XSAVES area
Date: Tue, 24 Jan 2017 09:08:10 +0100	[thread overview]
Message-ID: <20170124080810.GA11694@gmail.com> (raw)
In-Reply-To: <20170124020921.GC9969@pek-khao-d1>


* Kevin Hao <haokexin@gmail.com> wrote:

> > other than helping to hide bugs?
> 
> Why do you think it hide the bug? In contrast, I think my patch fixes what the 
> bug really is. The memory area we fake up is bug, we should fix it there.

The intention is to have a single FPU format set at bootup and xcomp_bv is 
essentially an invariant (constant) inherited by all tasks from early boot. In 
that sense setting xsave.header.xcomp_bv in copyin_to_xsaves() is misplaced.

So I combined the two commits: I kept your original fix but applied Yu-cheng Yu's 
patch that moves the initialization from copyin_to_xsaves() to fpstate_init().

Thanks,

	Ingo

  parent reply	other threads:[~2017-01-24  8:08 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-22  8:50 [PATCH] x86/fpu: set the xcomp_bv when we fake up a XSAVES area Kevin Hao
2017-01-23  8:28 ` [tip:x86/urgent] x86/fpu: Set " tip-bot for Kevin Hao
2017-01-23 15:36   ` Dave Hansen
2017-01-23 16:55     ` Yu-cheng Yu
2017-01-23 17:23       ` Dave Hansen
2017-01-23 20:57         ` Yu-cheng Yu
2017-01-23 21:10           ` Dave Hansen
2017-01-23 21:16             ` Yu-cheng Yu
2017-01-23 21:28               ` Dave Hansen
2017-01-24  0:14               ` Kevin Hao
2017-01-24  0:53                 ` Dave Hansen
2017-01-24  1:50                   ` Kevin Hao
2017-01-24  2:01                     ` Dave Hansen
2017-01-24  2:09                       ` Kevin Hao
2017-01-24  2:38                         ` Dave Hansen
2017-01-24  5:18                           ` Kevin Hao
2017-01-24  8:08                         ` Ingo Molnar [this message]
2017-01-23  9:43 ` tip-bot for Kevin Hao
2017-02-14 16:47   ` Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170124080810.GA11694@gmail.com \
    --to=mingo@kernel.org \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=dvlasenk@redhat.com \
    --cc=fenghua.yu@intel.com \
    --cc=haokexin@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=quentin.casasnovas@oracle.com \
    --cc=riel@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=yu-cheng.yu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.