From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jQdnElDFu9djwJ8//igK5TWMQOehTO7KM79mIoRLSP8=; b=sb5b+VezaAv3NpPXo6umABnQ6+GnxgUzEwo7eeeP+rRPghN96TepnFD6/r+H+QBc/T AeFXpadw8za+Z3KALZ9N8qMWoehtq1rPQ6qXiXKSeSnT4F/dYhAlHuhZWP/LbOWAIsn4 j2zHhGYvh1rdCo0G9zggX0vXpVYHQTGhXSI9KcsMAmGbY7eNA2mM9vE0z4euOkqsqOEz wRwcdvfDX6l9kgtlgzdeQrfgVdMkcrsjpHuDNu0AAhBCb11FxT0lmKErQUk6LaQO/6yz xc/CbOpjqLO59iV0asRRUY2c2NyMGiB1Qpi2yQTgp8cal8SRXrjtiOZA0dLrITETGHpa Lz+Q== Date: Tue, 24 Jan 2017 10:10:41 -0800 From: Stephen Hemminger Message-ID: <20170124101041.55c2ab39@xeon-e3> In-Reply-To: <20170121200133.1864-1-linus.luessing@c0d3.blue> References: <20170121200133.1864-1-linus.luessing@c0d3.blue> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Bridge] [PATCH net-next v5] bridge: multicast to unicast List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Linus =?UTF-8?B?TMO8c3Npbmc=?= Cc: Nikolay Aleksandrov , netdev@vger.kernel.org, bridge@lists.linux-foundation.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, "David S . Miller" , Felix Fietkau On Sat, 21 Jan 2017 21:01:32 +0100 Linus L=C3=BCssing wrote: > @@ -726,12 +729,32 @@ struct net_bridge_port_group *br_multicast_new_port= _group( > hlist_add_head(&p->mglist, &port->mglist); > setup_timer(&p->timer, br_multicast_port_group_expired, > (unsigned long)p); > + > + if (src) > + memcpy(p->eth_addr, src, ETH_ALEN); > + else > + memset(p->eth_addr, 0xff, ETH_ALEN); > + > return p; > } Maybe use ether_addr_copy here, but is not performance critical From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pg0-f46.google.com ([74.125.83.46]:36396 "EHLO mail-pg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763AbdAXSKv (ORCPT ); Tue, 24 Jan 2017 13:10:51 -0500 Received: by mail-pg0-f46.google.com with SMTP id t6so56811642pgt.3 for ; Tue, 24 Jan 2017 10:10:51 -0800 (PST) Date: Tue, 24 Jan 2017 10:10:41 -0800 From: Stephen Hemminger To: Linus =?UTF-8?B?TMO8c3Npbmc=?= Cc: netdev@vger.kernel.org, "David S . Miller" , Felix Fietkau , Nikolay Aleksandrov , bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH net-next v5] bridge: multicast to unicast Message-ID: <20170124101041.55c2ab39@xeon-e3> (sfid-20170124_191103_474938_8757A5B1) In-Reply-To: <20170121200133.1864-1-linus.luessing@c0d3.blue> References: <20170121200133.1864-1-linus.luessing@c0d3.blue> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sat, 21 Jan 2017 21:01:32 +0100 Linus L=C3=BCssing wrote: > @@ -726,12 +729,32 @@ struct net_bridge_port_group *br_multicast_new_port= _group( > hlist_add_head(&p->mglist, &port->mglist); > setup_timer(&p->timer, br_multicast_port_group_expired, > (unsigned long)p); > + > + if (src) > + memcpy(p->eth_addr, src, ETH_ALEN); > + else > + memset(p->eth_addr, 0xff, ETH_ALEN); > + > return p; > } Maybe use ether_addr_copy here, but is not performance critical From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751009AbdAXSKx (ORCPT ); Tue, 24 Jan 2017 13:10:53 -0500 Received: from mail-pf0-f176.google.com ([209.85.192.176]:34820 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750739AbdAXSKv (ORCPT ); Tue, 24 Jan 2017 13:10:51 -0500 Date: Tue, 24 Jan 2017 10:10:41 -0800 From: Stephen Hemminger To: Linus =?UTF-8?B?TMO8c3Npbmc=?= Cc: netdev@vger.kernel.org, "David S . Miller" , Felix Fietkau , Nikolay Aleksandrov , bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH net-next v5] bridge: multicast to unicast Message-ID: <20170124101041.55c2ab39@xeon-e3> In-Reply-To: <20170121200133.1864-1-linus.luessing@c0d3.blue> References: <20170121200133.1864-1-linus.luessing@c0d3.blue> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v0OIAv5Z001049 On Sat, 21 Jan 2017 21:01:32 +0100 Linus Lüssing wrote: > @@ -726,12 +729,32 @@ struct net_bridge_port_group *br_multicast_new_port_group( > hlist_add_head(&p->mglist, &port->mglist); > setup_timer(&p->timer, br_multicast_port_group_expired, > (unsigned long)p); > + > + if (src) > + memcpy(p->eth_addr, src, ETH_ALEN); > + else > + memset(p->eth_addr, 0xff, ETH_ALEN); > + > return p; > } Maybe use ether_addr_copy here, but is not performance critical