From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=p/XfdFip30RoTnsv4G2HaNKpqyrr5Vhjb7XmyAhIhLg=; b=Q5yTP3a5upUsisRqN5cT+bqmXD6EpVUpXecNr1SCQ/ZdYKOIfMQhims+Gw+5E3Uj1/ M3kYGkzwlOTE7terLCDrOgIEQGCd4dMg+2uvx2Jqwal4HHQWjVriIIcdwx36TvGRq6Eg k8dqGDfWUEUyYnpfqIywcfy29fpnOiUbcU4moF8yYjYnDEV+JxJyaiQnaAMnB18i+Vx4 8tbM0l3NFlzDkVjklLkbpsKHssFefvqoe18YX3fZhJqq8vB82+yZ8TQGBduaGbwddaOc 7yFM6EopCoZzklXuwcMYeTn9ew8qTPFX+f73MrH6kc6cVTzlmuLAGu+xO0zFYtc6noMz PLnQ== Date: Tue, 24 Jan 2017 10:12:15 -0800 From: Stephen Hemminger Message-ID: <20170124101215.4e3017b2@xeon-e3> In-Reply-To: <20170121200133.1864-1-linus.luessing@c0d3.blue> References: <20170121200133.1864-1-linus.luessing@c0d3.blue> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Bridge] [PATCH net-next v5] bridge: multicast to unicast List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Linus =?UTF-8?B?TMO8c3Npbmc=?= Cc: Nikolay Aleksandrov , netdev@vger.kernel.org, bridge@lists.linux-foundation.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, "David S . Miller" , Felix Fietkau On Sat, 21 Jan 2017 21:01:32 +0100 Linus L=C3=BCssing wrote: > +static bool br_port_group_equal(struct net_bridge_port_group *p, > + struct net_bridge_port *port, > + const unsigned char *src) > +{ > + if (p->port !=3D port) > + return false; > + > + if (!(port->flags & BR_MULTICAST_TO_UNICAST)) > + return true; > + > + return ether_addr_equal(src, p->eth_addr); > +} > + I prefer that argument to functions like this be const. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pg0-f43.google.com ([74.125.83.43]:35716 "EHLO mail-pg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751141AbdAXSMZ (ORCPT ); Tue, 24 Jan 2017 13:12:25 -0500 Received: by mail-pg0-f43.google.com with SMTP id 194so56788731pgd.2 for ; Tue, 24 Jan 2017 10:12:20 -0800 (PST) Date: Tue, 24 Jan 2017 10:12:15 -0800 From: Stephen Hemminger To: Linus =?UTF-8?B?TMO8c3Npbmc=?= Cc: netdev@vger.kernel.org, "David S . Miller" , Felix Fietkau , Nikolay Aleksandrov , bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH net-next v5] bridge: multicast to unicast Message-ID: <20170124101215.4e3017b2@xeon-e3> (sfid-20170124_191229_855228_3C3D27F5) In-Reply-To: <20170121200133.1864-1-linus.luessing@c0d3.blue> References: <20170121200133.1864-1-linus.luessing@c0d3.blue> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sat, 21 Jan 2017 21:01:32 +0100 Linus L=C3=BCssing wrote: > +static bool br_port_group_equal(struct net_bridge_port_group *p, > + struct net_bridge_port *port, > + const unsigned char *src) > +{ > + if (p->port !=3D port) > + return false; > + > + if (!(port->flags & BR_MULTICAST_TO_UNICAST)) > + return true; > + > + return ether_addr_equal(src, p->eth_addr); > +} > + I prefer that argument to functions like this be const. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751165AbdAXSMd (ORCPT ); Tue, 24 Jan 2017 13:12:33 -0500 Received: from mail-pf0-f175.google.com ([209.85.192.175]:34965 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751146AbdAXSMa (ORCPT ); Tue, 24 Jan 2017 13:12:30 -0500 Date: Tue, 24 Jan 2017 10:12:15 -0800 From: Stephen Hemminger To: Linus =?UTF-8?B?TMO8c3Npbmc=?= Cc: netdev@vger.kernel.org, "David S . Miller" , Felix Fietkau , Nikolay Aleksandrov , bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH net-next v5] bridge: multicast to unicast Message-ID: <20170124101215.4e3017b2@xeon-e3> In-Reply-To: <20170121200133.1864-1-linus.luessing@c0d3.blue> References: <20170121200133.1864-1-linus.luessing@c0d3.blue> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v0OICf4u001864 On Sat, 21 Jan 2017 21:01:32 +0100 Linus Lüssing wrote: > +static bool br_port_group_equal(struct net_bridge_port_group *p, > + struct net_bridge_port *port, > + const unsigned char *src) > +{ > + if (p->port != port) > + return false; > + > + if (!(port->flags & BR_MULTICAST_TO_UNICAST)) > + return true; > + > + return ether_addr_equal(src, p->eth_addr); > +} > + I prefer that argument to functions like this be const.