From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Thumshirn Subject: Re: [PATCH 1/2] qla2xxx: Fix a recently introduced memory leak Date: Tue, 24 Jan 2017 13:10:17 +0100 Message-ID: <20170124121017.GE3609@linux-x5ow.site> References: <20170123163446.9227-1-bart.vanassche@sandisk.com> <20170123163446.9227-2-bart.vanassche@sandisk.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20170123163446.9227-2-bart.vanassche@sandisk.com> Sender: stable-owner@vger.kernel.org To: Bart Van Assche Cc: "Martin K . Petersen" , linux-scsi@vger.kernel.org, Michael Hernandez , Himanshu Madhani , Christoph Hellwig , stable@vger.kernel.org List-Id: linux-scsi@vger.kernel.org On Mon, Jan 23, 2017 at 08:34:45AM -0800, Bart Van Assche wrote: > qla2x00_probe_one() allocates IRQs before it initializes rsp_q_map > so IRQs must be freed even if rsp_q_map allocation did not occur. > This was detected by kmemleak. > > Fixes: 4fa183455988 ("scsi: qla2xxx: Utilize pci_alloc_irq_vectors/pci_free_irq_vectors calls") > Signed-off-by: Bart Van Assche > Cc: Michael Hernandez > Cc: Himanshu Madhani > Cc: Christoph Hellwig > Cc: > --- Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:34984 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751000AbdAXMKW (ORCPT ); Tue, 24 Jan 2017 07:10:22 -0500 Date: Tue, 24 Jan 2017 13:10:17 +0100 From: Johannes Thumshirn To: Bart Van Assche Cc: "Martin K . Petersen" , linux-scsi@vger.kernel.org, Michael Hernandez , Himanshu Madhani , Christoph Hellwig , stable@vger.kernel.org Subject: Re: [PATCH 1/2] qla2xxx: Fix a recently introduced memory leak Message-ID: <20170124121017.GE3609@linux-x5ow.site> References: <20170123163446.9227-1-bart.vanassche@sandisk.com> <20170123163446.9227-2-bart.vanassche@sandisk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170123163446.9227-2-bart.vanassche@sandisk.com> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Jan 23, 2017 at 08:34:45AM -0800, Bart Van Assche wrote: > qla2x00_probe_one() allocates IRQs before it initializes rsp_q_map > so IRQs must be freed even if rsp_q_map allocation did not occur. > This was detected by kmemleak. > > Fixes: 4fa183455988 ("scsi: qla2xxx: Utilize pci_alloc_irq_vectors/pci_free_irq_vectors calls") > Signed-off-by: Bart Van Assche > Cc: Michael Hernandez > Cc: Himanshu Madhani > Cc: Christoph Hellwig > Cc: > --- Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N�rnberg GF: Felix Imend�rffer, Jane Smithard, Graham Norton HRB 21284 (AG N�rnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850