From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56189) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cW0Mo-0005iQ-5K for qemu-devel@nongnu.org; Tue, 24 Jan 2017 07:38:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cW0Mn-0002gt-5F for qemu-devel@nongnu.org; Tue, 24 Jan 2017 07:38:30 -0500 Date: Tue, 24 Jan 2017 12:38:17 +0000 From: "Daniel P. Berrange" Message-ID: <20170124123817.GM14563@redhat.com> Reply-To: "Daniel P. Berrange" References: <20170103160556.9895-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2] iotests: record separate timings per format, protocol pair List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, Kevin Wolf , Max Reitz , qemu-block@nongnu.org On Tue, Jan 03, 2017 at 11:08:39AM -0600, Eric Blake wrote: > On 01/03/2017 10:05 AM, Daniel P. Berrange wrote: > > The 'check' program records timings for each test that > > is run. These timings are only valid, however, for a > > particular format/protocol combination. So if frequently > > running 'check' with a variety of different formats or > > protocols, the times printed can be very misleading. > > > > Instead of having a single 'check.time' file, maintain > > multiple 'check.time-$IMGPROTO-$IMGFMT' files. > > > > Signed-off-by: Daniel P. Berrange > > --- > > Changed in v2: > > > > - Use a separate file per format/protocol, instead of > > throwing away data each time format/protocol changes > > between runs (Eric) > > > > Reviewed-by: Eric Blake Ping, any block maintainers want to take this simple patch ? Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|