From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 5/5] perf, tools, script: Add brstackasm output for branch stacks
Date: Tue, 24 Jan 2017 15:54:10 -0300 [thread overview]
Message-ID: <20170124185410.GF10340@kernel.org> (raw)
In-Reply-To: <20170119014150.19218-6-andi@firstfloor.org>
Em Wed, Jan 18, 2017 at 05:41:50PM -0800, Andi Kleen escreveu:
> + memset(&al, 0, sizeof(al));
> + if (end - start > MAXBB - MAXINSN) {
> + if (last)
> + printf("\tbrstack does not reach to final jump (%" PRIx64 "-%" PRIx64 ")\n",
> + start, end);
> + else
> + printf("\tblock %" PRIx64 "-%" PRIx64 " (%ld) too long to dump\n",
> + start, end, end - start);
> + return 0;
Those are multiline if/else blocks, one has to use {}, additionally (end
- start) should be, just like the other bits PRI, fixing...
This actually broke the build in some distros, like fedora:24
crossbuilding to ARC-uClibc.
- Arnaldo
next prev parent reply other threads:[~2017-01-24 18:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 1:41 New attempt at adding an disassembler to perf Andi Kleen
2017-01-19 1:41 ` [PATCH 1/5] perf, tools: Add probing for xed Andi Kleen
2017-01-19 1:41 ` [PATCH 2/5] perf, tools: Add one liner warning for disabled features Andi Kleen
2017-01-19 1:41 ` [PATCH 3/5] perf, tools: Add disassembler for x86 using the XED library Andi Kleen
2017-01-19 1:41 ` [PATCH 4/5] perf, tools, script: Add support for printing assembler Andi Kleen
2017-01-23 19:49 ` Arnaldo Carvalho de Melo
2017-01-23 19:55 ` Andi Kleen
2017-01-23 20:06 ` Arnaldo Carvalho de Melo
2017-01-19 1:41 ` [PATCH 5/5] perf, tools, script: Add brstackasm output for branch stacks Andi Kleen
2017-01-24 18:54 ` Arnaldo Carvalho de Melo [this message]
2017-01-19 15:36 ` New attempt at adding an disassembler to perf Jiri Olsa
2017-01-19 16:54 ` Andi Kleen
2017-01-20 13:22 ` Jiri Olsa
-- strict thread matches above, loose matches on Subject: below --
2017-01-10 1:02 New attempt at adding an disassembler to perf v2 Andi Kleen
2017-01-10 1:02 ` [PATCH 5/5] perf, tools, script: Add brstackasm output for branch stacks Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124185410.GF10340@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.