From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Will Deacon <will.deacon@arm.com>
Cc: He Kuang <hekuang@huawei.com>,
peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, jolsa@redhat.com,
mhiramat@kernel.org, wangnan0@huawei.com,
bintian.wang@huawei.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] perf probe: Fix wrong register name for arm64
Date: Tue, 24 Jan 2017 16:11:11 -0300 [thread overview]
Message-ID: <20170124191111.GH10340@kernel.org> (raw)
In-Reply-To: <20170124103015.1936-2-hekuang@huawei.com>
Em Tue, Jan 24, 2017 at 10:30:14AM +0000, He Kuang escreveu:
> The register name of arm64 architecture is x0-x31 not r0-r31, this
> patch changes this typo.
>
> Before this patch:
Will, are you ok with this one? I'll make sure I'll forward patches in
this area to you if you're not on the CC list,
- Arnaldo
> # perf probe --definition 'sys_write count'
> p:probe/sys_write _text+1502872 count=%r2:s64
>
> # echo 'p:probe/sys_write _text+1502872 count=%r2:s64' > \
> /sys/kernel/debug/tracing/kprobe_events
> Parse error at argument[0]. (-22)
>
> After this patch:
>
> # perf probe --definition 'sys_write count'
> p:probe/sys_write _text+1502872 count=%x2:s64
>
> # echo 'p:probe/sys_write _text+1502872 count=%x2:s64' > \
> /sys/kernel/debug/tracing/kprobe_events
> # echo 1 >/sys/kernel/debug/tracing/events/probe/enable
> # cat /sys/kernel/debug/tracing/trace
> ...
> sh-422 [000] d... 650.495930: sys_write: (SyS_write+0x0/0xc8) count=22
> sh-422 [000] d... 651.102389: sys_write: (SyS_write+0x0/0xc8) count=26
> sh-422 [000] d... 651.358653: sys_write: (SyS_write+0x0/0xc8) count=86
>
> Signed-off-by: He Kuang <hekuang@huawei.com>
> ---
> tools/perf/arch/arm64/include/dwarf-regs-table.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/tools/perf/arch/arm64/include/dwarf-regs-table.h b/tools/perf/arch/arm64/include/dwarf-regs-table.h
> index 2675936..36e375f 100644
> --- a/tools/perf/arch/arm64/include/dwarf-regs-table.h
> +++ b/tools/perf/arch/arm64/include/dwarf-regs-table.h
> @@ -2,12 +2,12 @@
> /* This is included in perf/util/dwarf-regs.c */
>
> static const char * const aarch64_regstr_tbl[] = {
> - "%r0", "%r1", "%r2", "%r3", "%r4",
> - "%r5", "%r6", "%r7", "%r8", "%r9",
> - "%r10", "%r11", "%r12", "%r13", "%r14",
> - "%r15", "%r16", "%r17", "%r18", "%r19",
> - "%r20", "%r21", "%r22", "%r23", "%r24",
> - "%r25", "%r26", "%r27", "%r28", "%r29",
> + "%x0", "%x1", "%x2", "%x3", "%x4",
> + "%x5", "%x6", "%x7", "%x8", "%x9",
> + "%x10", "%x11", "%x12", "%x13", "%x14",
> + "%x15", "%x16", "%x17", "%x18", "%x19",
> + "%x20", "%x21", "%x22", "%x23", "%x24",
> + "%x25", "%x26", "%x27", "%x28", "%x29",
> "%lr", "%sp",
> };
> #endif
> --
> 1.8.5.2
next prev parent reply other threads:[~2017-01-24 19:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 10:30 [PATCH 0/2] Support bpf prologue for arm64 He Kuang
2017-01-24 10:30 ` [PATCH 1/2] perf probe: Fix wrong register name " He Kuang
2017-01-24 19:11 ` Arnaldo Carvalho de Melo [this message]
2017-01-25 9:22 ` Will Deacon
2017-01-26 1:24 ` Masami Hiramatsu
2017-01-26 15:28 ` [tip:perf/core] " tip-bot for He Kuang
2017-05-03 8:54 ` [PATCH 1/2] " Pratyush Anand
2017-01-24 10:30 ` [PATCH 2/2] perf tools: Introduce regs_query_register_offset() " He Kuang
2017-01-24 18:25 ` Will Deacon
2017-01-24 19:09 ` Arnaldo Carvalho de Melo
2017-01-25 7:23 ` [PATCH 2/2 v2] perf tools: Enable bpf prologue " He Kuang
2017-01-25 7:23 ` He Kuang
2017-01-25 13:32 ` Will Deacon
2017-01-25 13:32 ` Will Deacon
2017-01-26 1:49 ` Masami Hiramatsu
2017-01-26 1:49 ` Masami Hiramatsu
2017-01-26 16:52 ` Will Deacon
2017-01-26 16:52 ` Will Deacon
2017-01-26 19:31 ` Arnaldo Carvalho de Melo
2017-01-26 19:31 ` Arnaldo Carvalho de Melo
2017-02-03 11:08 ` Hekuang
2017-02-03 11:08 ` Hekuang
2017-01-26 1:51 ` Masami Hiramatsu
2017-01-26 1:51 ` Masami Hiramatsu
2017-01-25 7:26 ` [PATCH 2/2] perf tools: Introduce regs_query_register_offset() " Hekuang
2017-01-24 15:56 ` [PATCH 0/2] Support bpf prologue " Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124191111.GH10340@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bintian.wang@huawei.com \
--cc=hekuang@huawei.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.