All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] micropython-lib: depend on pcre
Date: Wed, 25 Jan 2017 09:54:50 +1300	[thread overview]
Message-ID: <20170125095450.2cb6aea4@free-electrons.com> (raw)
In-Reply-To: <20170124101423.11479-2-judge.packham@gmail.com>

Hello,

On Tue, 24 Jan 2017 23:14:22 +1300, Chris Packham wrote:
> The micropython libs load libpcre dynamically using the foreign function
> interface (libffi). Without pcre the build will succeed but at run time
> anything that uses the 're' module will have issues.

If it's only a runtime dependency, then why do you have
"MICROPYTHON_LIBS_DEPENDENCIES = pcre" ? Selecting it in Config.in is
sufficient to ensure that it will be built "at some point" during the
build. In such cases, we normally do just:

	select BR2_PACKAGE_PCRE # runtime

and that's it.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  parent reply	other threads:[~2017-01-24 20:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-24 10:14 [Buildroot] [PATCH 1/3] micropython: bump version to v1.8.7 Chris Packham
2017-01-24 10:14 ` [Buildroot] [PATCH 2/3] micropython-lib: depend on pcre Chris Packham
2017-01-24 16:31   ` Peter Korsgaard
2017-01-24 20:54   ` Thomas Petazzoni [this message]
2017-01-25  7:13     ` Chris Packham
2017-01-24 10:14 ` [Buildroot] [PATCH 3/3] micropython-lib: bump version to v1.8.6 Chris Packham
2017-01-24 16:31   ` Peter Korsgaard
2017-01-24 16:31 ` [Buildroot] [PATCH 1/3] micropython: bump version to v1.8.7 Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170125095450.2cb6aea4@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.