From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Vincent Abriou <vincent.abriou@st.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/sti: Fix compilation failure for drm_framebuffer.pixel_format
Date: Wed, 25 Jan 2017 14:23:36 +0200 [thread overview]
Message-ID: <20170125122336.GS31595@intel.com> (raw)
In-Reply-To: <20170125101044.8956-1-chris@chris-wilson.co.uk>
On Wed, Jan 25, 2017 at 10:10:44AM +0000, Chris Wilson wrote:
> drivers/gpu/drm/sti/sti_plane.c:76:33: error: ‘struct drm_framebuffer’
> has no member named ‘pixel_format’; did you mean ‘format’?
>
> I didn't look to hard at the casting to a char * and just did a
> mechanical transformation of s/pixel_format/format->format/ as given in
> commit 438b74a5497c ("drm: Nuke fb->pixel_format").
lgtm
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Fixes: 438b74a5497c ("drm: Nuke fb->pixel_format")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> Cc: Vincent Abriou <vincent.abriou@st.com>
> ---
> drivers/gpu/drm/sti/sti_plane.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_plane.c b/drivers/gpu/drm/sti/sti_plane.c
> index 699094c559b4..427d8f58c6b1 100644
> --- a/drivers/gpu/drm/sti/sti_plane.c
> +++ b/drivers/gpu/drm/sti/sti_plane.c
> @@ -73,7 +73,7 @@ void sti_plane_update_fps(struct sti_plane *plane,
> plane->drm_plane.name,
> plane->drm_plane.fb->width,
> plane->drm_plane.fb->height,
> - (char *)&plane->drm_plane.fb->pixel_format,
> + (char *)&plane->drm_plane.fb->format->format,
> fpks / 1000, fpks % 1000,
> sti_plane_to_str(plane));
> }
> --
> 2.11.0
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-01-25 12:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 10:10 [PATCH] drm/sti: Fix compilation failure for drm_framebuffer.pixel_format Chris Wilson
2017-01-25 10:47 ` Vincent ABRIOU
2017-01-25 12:23 ` Ville Syrjälä [this message]
2017-01-25 12:46 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170125122336.GS31595@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=vincent.abriou@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.