From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752199AbdAYO25 (ORCPT ); Wed, 25 Jan 2017 09:28:57 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:34070 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750755AbdAYO24 (ORCPT ); Wed, 25 Jan 2017 09:28:56 -0500 Date: Wed, 25 Jan 2017 15:28:52 +0100 From: Peter Zijlstra To: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , linux-kernel@vger.kernel.org Cc: Steven Rostedt Subject: Re: [PATCH] kasan: Respect /proc/sys/kernel/traceoff_on_warning Message-ID: <20170125142852.GE6536@twins.programming.kicks-ass.net> References: <20170125142524.GQ6515@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170125142524.GQ6515@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 25, 2017 at 03:25:24PM +0100, Peter Zijlstra wrote: > > After much waiting I finally reproduced a KASAN issue, only to find my > trace-buffer empty of useful information because it got spooled out :/ > > Make kasan_report honour the /proc/sys/kernel/traceoff_on_warning > interface. > > Signed-off-by: Peter Zijlstra (Intel) > --- Seems to compile better when you add the required header files... mm/kasan/report.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mm/kasan/report.c b/mm/kasan/report.c index b82b3e2..3653ed1 100644 --- a/mm/kasan/report.c +++ b/mm/kasan/report.c @@ -24,6 +24,7 @@ #include #include #include +#include #include @@ -300,6 +301,8 @@ void kasan_report(unsigned long addr, size_t size, if (likely(!kasan_report_enabled())) return; + disable_trace_on_warning(); + info.access_addr = (void *)addr; info.access_size = size; info.is_write = is_write;