From: Peter Zijlstra <peterz@infradead.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Michal Marek <mmarek@suse.com>, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v2] tools build: add tools tree support for 'make -s'
Date: Wed, 25 Jan 2017 16:12:57 +0100 [thread overview]
Message-ID: <20170125151257.GO6500@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <e8967562ef640c3ae9a76da4ae0f4e47df737c34.1484799200.git.jpoimboe@redhat.com>
On Wed, Jan 18, 2017 at 10:16:55PM -0600, Josh Poimboeuf wrote:
> When doing a kernel build with 'make -s', everything is silenced except
> the objtool build. That's because the tools tree support for silent
> builds is some combination of missing and broken.
>
> Three changes are needed to fix it:
>
> - Makefile: propagate '-s' to the sub-make's MAKEFLAGS variable so the
> tools Makefiles can see it.
>
> - tools/scripts/Makefile.include: fix the tools Makefiles' ability to
> recognize '-s'. The MAKE_VERSION and MAKEFLAGS checks are copied from
> the top-level Makefile. This silences the "DESCEND objtool" message.
>
> - tools/build/Makefile.build: add support to the tools Build files for
> recognizing '-s'. Again the MAKE_VERSION and MAKEFLAGS checks are
> copied from the top-level Makefile. This silences all the object
> compile/link messages.
>
> Reported-by: Peter Zijlstra <peterz@infradead.org>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Awesome, seems to work!
Tested-by: Peter Zijlstra (Intel) <peterz@infradead.org>
next prev parent reply other threads:[~2017-01-25 15:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 3:46 [PATCH] tools build: add tools tree support for 'make -s' Josh Poimboeuf
2017-01-19 4:16 ` [PATCH v2] " Josh Poimboeuf
2017-01-25 15:12 ` Peter Zijlstra [this message]
2017-01-26 19:30 ` Arnaldo Carvalho de Melo
2017-02-01 14:37 ` [tip:perf/core] tools build: Add " tip-bot for Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170125151257.GO6500@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mmarek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.