From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Paul Durrant <Paul.Durrant@citrix.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Wei Liu <wei.liu2@citrix.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] xennet_start_xmit assumptions
Date: Wed, 25 Jan 2017 10:45:46 -0500 [thread overview]
Message-ID: <20170125154546.GF2212@oracle.com> (raw)
In-Reply-To: <fa531e2ed014488baa10556c724e176c@AMSPEX02CL03.citrite.net>
On (01/25/17 15:06), Paul Durrant wrote:
>
> Making netfront cope with a fully non-linear skb looks like it would
> be quite intrusive and probably not worth it so I opted for just doing
> the ETH_HLEN pull-tail if necessary. Can you check it works for you?
I tested it, and it works fine, but note that DaveM's comments in
this thread: the DKI is that we *must* provide at least the hard_header_len
in the non-paged part of the skb. So might not even be necessary to handle
the fully non-linear skb (though it's probably prudent to check
and bail for this, as your patch does)
I just posted an RFC patch for fixing the pf_packet layer,
just in case other drivers like xen_netfront dont explicitly
check for this
http://patchwork.ozlabs.org/patch/719236/
next prev parent reply other threads:[~2017-01-25 15:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 15:31 xennet_start_xmit assumptions Sowmini Varadhan
2017-01-18 19:25 ` [Xen-devel] " Konrad Rzeszutek Wilk
2017-01-19 9:36 ` Paul Durrant
2017-01-19 11:14 ` [Xen-devel] " Sowmini Varadhan
2017-01-19 11:31 ` Paul Durrant
2017-01-19 11:37 ` [Xen-devel] " Sowmini Varadhan
2017-01-19 11:37 ` Sowmini Varadhan
2017-01-19 16:37 ` David Miller
2017-01-19 18:47 ` Sowmini Varadhan
2017-01-19 22:41 ` Sowmini Varadhan
2017-01-19 22:41 ` [Xen-devel] " Sowmini Varadhan
2017-01-20 19:30 ` David Miller
2017-01-20 19:30 ` [Xen-devel] " David Miller
2017-01-20 20:03 ` Sowmini Varadhan
2017-01-20 20:03 ` Sowmini Varadhan
2017-01-25 15:06 ` Paul Durrant
2017-01-25 15:06 ` [Xen-devel] " Paul Durrant
2017-01-25 15:45 ` Sowmini Varadhan [this message]
2017-01-25 15:45 ` Sowmini Varadhan
2017-01-19 11:14 ` Sowmini Varadhan
2017-01-18 19:25 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170125154546.GF2212@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=Paul.Durrant@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.