All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleksandr Tymoshenko <gonzo@bluezbox.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] FAT12 regression after 8d48c92b45aea91e2a2be90f2ed93677e85526f1
Date: Wed, 25 Jan 2017 15:25:46 -0800	[thread overview]
Message-ID: <20170125232546.GA93084@bluezbox.com> (raw)

Hello,

U-Boot 2017.01 and master branch is broken on BeagleBone Black
with boot partition formatted as FAT12, it hang after printing "Loading
u-boot.img" message. I bisected regression to this patch:

http://lists.denx.de/pipermail/u-boot/2016-December/276305.html

This code simplification is not going to work on architectures
with strict alignment requirements:

+               ret = FAT2CPU16(*(__u16 *)(mydata->fatbuf + off16));

fatbuf is a pointer to __u8 and off16 can take any values so
mydata->fatbuf + off16 is not guaranteed to be 16-bits aligned
and 16-bit access to non-aligned address will cause exception.

-- 
gonzo

             reply	other threads:[~2017-01-25 23:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-25 23:25 Oleksandr Tymoshenko [this message]
2017-01-26  6:40 ` [U-Boot] FAT12 regression after 8d48c92b45aea91e2a2be90f2ed93677e85526f1 Heiko Schocher
2017-01-26 17:55 ` [U-Boot] [PATCH] fs/fat: Fix unaligned __u16 reads for FAT12 access Brüns, Stefan
2017-01-26 19:50   ` Oleksandr Tymoshenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170125232546.GA93084@bluezbox.com \
    --to=gonzo@bluezbox.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.