From: "hch@lst.de" <hch@lst.de>
To: Bart Van Assche <Bart.VanAssche@sandisk.com>
Cc: "hch@lst.de" <hch@lst.de>, "axboe@fb.com" <axboe@fb.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"mchristi@redhat.com" <mchristi@redhat.com>,
"hare@suse.de" <hare@suse.de>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [PATCH] SCSI core: Fix WRITE SAME handling
Date: Thu, 26 Jan 2017 09:24:53 +0100 [thread overview]
Message-ID: <20170126082453.GA11768@lst.de> (raw)
In-Reply-To: <1485384261.2646.8.camel@sandisk.com>
On Wed, Jan 25, 2017 at 10:44:41PM +0000, Bart Van Assche wrote:
> On Wed, 2017-01-25 at 11:37 +0100, Christoph Hellwig wrote:
> > > Fixes: f80de881d8df ("sd: remove __data_len hack for WRITE SAME")
> >
> > I think the better fix is to simply revert this commit.
>
> Hello Christoph,
>
> Do you mean reverting commit f80de881d8df only for kernel release v4.10
> or also for future releases? How about resubmitting a reworked version of
> commit f80de881d8df for kernel v4.11?
Let's revert it for good for now. This was a braino for me as the
real write same requests are very different from discards implemented
as write same. I have a WIP series that would change a lot in this
area, so additional churn before that would not be productive.
prev parent reply other threads:[~2017-01-26 8:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 1:21 [PATCH] SCSI core: Fix WRITE SAME handling Bart Van Assche
2017-01-25 10:37 ` Christoph Hellwig
2017-01-25 22:44 ` Bart Van Assche
2017-01-26 8:24 ` hch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170126082453.GA11768@lst.de \
--to=hch@lst.de \
--cc=Bart.VanAssche@sandisk.com \
--cc=axboe@fb.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mchristi@redhat.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.