From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com ([74.125.82.54]:38138 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753019AbdAZJYv (ORCPT ); Thu, 26 Jan 2017 04:24:51 -0500 Received: by mail-wm0-f54.google.com with SMTP id r144so73377531wme.1 for ; Thu, 26 Jan 2017 01:24:50 -0800 (PST) Date: Thu, 26 Jan 2017 10:24:46 +0100 From: Daniel Lezcano To: Chris Brandt Cc: Rob Herring , Mark Rutland , Simon Horman , Magnus Damm , Russell King , Thomas Gleixner , Geert Uytterhoeven , devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v4 2/2] clocksource: Add renesas-ostm timer driver Message-ID: <20170126092446.GF2021@mai> References: <20170126020707.4376-1-chris.brandt@renesas.com> <20170126020707.4376-3-chris.brandt@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170126020707.4376-3-chris.brandt@renesas.com> Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On Wed, Jan 25, 2017 at 09:07:07PM -0500, Chris Brandt wrote: > This patch adds a OSTM driver for the Renesas architecture. > The OS Timer (OSTM) has independent channels that can be > used as a freerun or interval times. > This driver uses the first probed device as a clocksource > and then any additional devices as clock events. > > Signed-off-by: Chris Brandt > --- > v3: > * Added more details to commit log > * Kconfig: SYS_SUPPORTS_RENESAS_OSTM to just RENESAS_OSTM > * removed all MODULE code (this driver is builtin only) > * removed items from 'struct ostm_device' > * changed ioread8 to readb The iowrite* conversion is missing. s/iowrite8/writeb/ s/iowrite32/writel/ Other than that the driver looks good to me. Thanks. -- Daniel