Re: [Qemu-devel] [PATCH v1 2/6] qemu-img: fix --image-opts usage with dd command

[Fam Zheng <famz@redhat.com>]

On Thu, 01/26 11:04, Daniel P. Berrange wrote:
> The --image-opts flag can only be used to affect the parsing
> of the source image. The target image has to be specified in
> the traditional style regardless, since it needs to be passed
> to the brdv_create() API which does not support the new style

"bdrv_create", if you respin :)

> opts.
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  qemu-img.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/qemu-img.c b/qemu-img.c
> index 391a141..629f9e9 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -4098,8 +4098,13 @@ static int img_dd(int argc, char **argv)
>          goto out;
>      }
>  
> -    blk2 = img_open(image_opts, out.filename, out_fmt, BDRV_O_RDWR,
> -                    false, false);
> +    /* TODO, we can't honour --image-opts for the target,
> +     * since it needs to be given in a format compatible
> +     * with the bdrv_create() call above which does not
> +     * support image-opts style.
> +     */
> +    blk2 = img_open_file(out.filename, out_fmt, BDRV_O_RDWR,
> +                         false, false);
>  
>      if (!blk2) {
>          ret = -1;
> -- 
> 2.9.3
> 
>