From: Andrew Lunn <andrew@lunn.ch>
To: "Sean Nyekjær" <sean.nyekjaer@prevas.dk>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v1] net: phy: micrel: add KSZ8795 ethernet switch
Date: Thu, 26 Jan 2017 19:12:07 +0100 [thread overview]
Message-ID: <20170126181207.GF5656@lunn.ch> (raw)
In-Reply-To: <732c14ff-f0cf-67d5-bcf9-cbbf9a4391b3@prevas.dk>
> I remove the word "Switch" from the commit message and phy name.
> The rest is okay?
Yes.
> What is generally being done when to phy's have the same id, micrel
> have done this many times...
It should not be a problem. When you write a switch driver for the
switch, it will be in device tree. Look at the Marvell Switches as an
example. Switches don't probe based on the ID in registers 2 and 3,
because switches often respond to many different addresses, or don't
have an ID in register 2 and 3.
So it should not matter if the switch and the PHYs embedded in the
switch have the same ID.
When do you plan to post your switch driver?
Andrew
next prev parent reply other threads:[~2017-01-26 18:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 7:58 [PATCH v1] net: phy: micrel: add KSZ8795 ethernet switch Sean Nyekjaer
2017-01-23 15:12 ` Andrew Lunn
2017-01-26 17:51 ` Sean Nyekjær
2017-01-26 18:12 ` Andrew Lunn [this message]
2017-01-27 7:42 ` Sean Nyekjær
2017-01-26 18:36 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170126181207.GF5656@lunn.ch \
--to=andrew@lunn.ch \
--cc=netdev@vger.kernel.org \
--cc=sean.nyekjaer@prevas.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.