From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 15/16] block: split scsi_request out of struct request Date: Thu, 26 Jan 2017 20:37:34 +0100 Message-ID: <20170126193734.GA26037@lst.de> References: <1485185361-29786-1-git-send-email-hch@lst.de> <1485185361-29786-16-git-send-email-hch@lst.de> <455a58ef-905c-abf9-ae59-ca98f003f31e@sandisk.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <455a58ef-905c-abf9-ae59-ca98f003f31e@sandisk.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Bart Van Assche Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, Mike Snitzer , Jens Axboe , dm-devel@redhat.com, Christoph Hellwig List-Id: dm-devel.ids On Thu, Jan 26, 2017 at 11:12:51AM -0800, Bart Van Assche wrote: > Where does the '* 3' come from? I think that deserves a comment. > Additionally, this patch introduces a new warning when building with W=1: It's a magic factor copied from the old code :( That beeing said I really wonder if we should keep the tracing for the scsi_requests fields at all. We have tracing in SCSI, and poking into these SCSI fields from block code is painful and just screams layering violations. Jens, any opinion on just removing the printout of the SCSI CDB for blktrace? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 26 Jan 2017 20:37:34 +0100 From: Christoph Hellwig To: Bart Van Assche Cc: Christoph Hellwig , Jens Axboe , Mike Snitzer , linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, dm-devel@redhat.com Subject: Re: [PATCH 15/16] block: split scsi_request out of struct request Message-ID: <20170126193734.GA26037@lst.de> References: <1485185361-29786-1-git-send-email-hch@lst.de> <1485185361-29786-16-git-send-email-hch@lst.de> <455a58ef-905c-abf9-ae59-ca98f003f31e@sandisk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <455a58ef-905c-abf9-ae59-ca98f003f31e@sandisk.com> Sender: linux-scsi-owner@vger.kernel.org List-ID: On Thu, Jan 26, 2017 at 11:12:51AM -0800, Bart Van Assche wrote: > Where does the '* 3' come from? I think that deserves a comment. > Additionally, this patch introduces a new warning when building with W=1: It's a magic factor copied from the old code :( That beeing said I really wonder if we should keep the tracing for the scsi_requests fields at all. We have tracing in SCSI, and poking into these SCSI fields from block code is painful and just screams layering violations. Jens, any opinion on just removing the printout of the SCSI CDB for blktrace?