From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754438AbdA0IPF (ORCPT ); Fri, 27 Jan 2017 03:15:05 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:54610 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754418AbdA0IPD (ORCPT ); Fri, 27 Jan 2017 03:15:03 -0500 Date: Fri, 27 Jan 2017 09:15:15 +0100 From: Greg Kroah-Hartman To: Tomas Winkler Cc: Alexander Usyskin , linux-kernel@vger.kernel.org, Andy Shevchenko Subject: Re: [char-misc-next V3] mei: simplify error handling via devres function. Message-ID: <20170127081515.GA29246@kroah.com> References: <1485443786-27337-1-git-send-email-tomas.winkler@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1485443786-27337-1-git-send-email-tomas.winkler@intel.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 26, 2017 at 05:16:26PM +0200, Tomas Winkler wrote: > Use devm_ and pcim_ functions to make error handling > simpler and code smaller and tidier. > > Based on original patch by > mei: me: use managed functions pcim_* and devm_* > https://lkml.org/lkml/2016/2/1/339 > > Signed-off-by: Tomas Winkler > Signed-off-by: Alexander Usyskin > Signed-off-by: Andy Shevchenko > --- > V2: Thanks Andy for review, integratd changes: > 1. Rename devm_mei_me_init back to mei_me_dev_init > they don't really belong to devm_ namespace. > 2. Revert pcim irq reservation change. > 3. Drop setting driver data to NULL on exit. > 4. Use directly mmio pointer received from pcim_iomap_table > V3: Remove pci_disable_msi, it is also handled by the system. Andy, any objection to this version? thanks, greg k-h