From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: v4.10-rc4 to v4.10-rc5: battery regression on Nokia N900 Date: Fri, 27 Jan 2017 12:09:47 +0100 Message-ID: <20170127110947.GA5335@amd> References: <20170123234912.GA2460@roeck-us.net> <20170124070639.GA5068@rzhang1-surface> <20170124073720.GB5603@amd> <88c94ea6-abe2-0f20-337e-e9ee00c883d8@roeck-us.net> <20170124175800.GA15070@amd> <20170124184526.GA25056@roeck-us.net> <20170125111233.GB3912@amd> <20170125120918.GA7936@pali> <1485481030.2469.15.camel@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1622167079368615621==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Guenter Roeck Cc: ivo.g.dimitrov.75@gmail.com, khilman@kernel.org, tony@atomide.com, aaro.koskinen@iki.fi, kernel list , sre@kernel.org, abcloriens@gmail.com, Pali =?iso-8859-1?Q?Roh=E1r?= , fabio.estevam@nxp.com, Zhang Rui , linux-omap@vger.kernel.org, patrikbachan@gmail.com, linux-arm-kernel , serge@hallyn.com List-Id: linux-omap@vger.kernel.org --===============1622167079368615621== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AhhlLboLdkugWU4S" Content-Disposition: inline --AhhlLboLdkugWU4S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > >If this is the case, you'd better set > >(struct thermal_zone_params)->no_hwmon when registering the thermal > >zone device, in which case, the hwmon device will not be created. > > > >In fact, I'd prefer to change tzp->no_hwmon to tzp->hwmon to not create > >hwmon I/F by default, and see if there is anyone using it. If yes, we > >can set the flag in soc thermal driver, explicitly, at meantime, a > >hwmon compatible name is required. > > > >But one foreseeable result is that we may get bug reports from end user > >that some sensors (acpitz, etc) are gone in 'sensors' output. And TBH, > >I'm not quite sure if this can be counted as a regression or not. > > >=20 > That sounds like fun. Changing bq27200-0 to bq27200_0 is Forbidden by > the ABI Police, but taking the entire device away is ok. Stop trying to break other people's systems. Thanks you. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --AhhlLboLdkugWU4S Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAliLKnsACgkQMOfwapXb+vLU/wCcDLC0OEATT+uy5EI/bLzaLKsF mUQAn2UUWxhWk1By8ParVSFpnua9LSPj =mCnF -----END PGP SIGNATURE----- --AhhlLboLdkugWU4S-- --===============1622167079368615621== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1622167079368615621==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: pavel@ucw.cz (Pavel Machek) Date: Fri, 27 Jan 2017 12:09:47 +0100 Subject: v4.10-rc4 to v4.10-rc5: battery regression on Nokia N900 In-Reply-To: References: <20170123234912.GA2460@roeck-us.net> <20170124070639.GA5068@rzhang1-surface> <20170124073720.GB5603@amd> <88c94ea6-abe2-0f20-337e-e9ee00c883d8@roeck-us.net> <20170124175800.GA15070@amd> <20170124184526.GA25056@roeck-us.net> <20170125111233.GB3912@amd> <20170125120918.GA7936@pali> <1485481030.2469.15.camel@intel.com> Message-ID: <20170127110947.GA5335@amd> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > >If this is the case, you'd better set > >(struct thermal_zone_params)->no_hwmon when registering the thermal > >zone device, in which case, the hwmon device will not be created. > > > >In fact, I'd prefer to change tzp->no_hwmon to tzp->hwmon to not create > >hwmon I/F by default, and see if there is anyone using it. If yes, we > >can set the flag in soc thermal driver, explicitly, at meantime, a > >hwmon compatible name is required. > > > >But one foreseeable result is that we may get bug reports from end user > >that some sensors (acpitz, etc) are gone in 'sensors' output. And TBH, > >I'm not quite sure if this can be counted as a regression or not. > > > > That sounds like fun. Changing bq27200-0 to bq27200_0 is Forbidden by > the ABI Police, but taking the entire device away is ok. Stop trying to break other people's systems. Thanks you. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 181 bytes Desc: Digital signature URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933679AbdA0LX7 (ORCPT ); Fri, 27 Jan 2017 06:23:59 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:50015 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934000AbdA0LWR (ORCPT ); Fri, 27 Jan 2017 06:22:17 -0500 Date: Fri, 27 Jan 2017 12:09:47 +0100 From: Pavel Machek To: Guenter Roeck Cc: Zhang Rui , Pali =?iso-8859-1?Q?Roh=E1r?= , sre@kernel.org, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com, serge@hallyn.com, abcloriens@gmail.com, fabio.estevam@nxp.com Subject: Re: v4.10-rc4 to v4.10-rc5: battery regression on Nokia N900 Message-ID: <20170127110947.GA5335@amd> References: <20170123234912.GA2460@roeck-us.net> <20170124070639.GA5068@rzhang1-surface> <20170124073720.GB5603@amd> <88c94ea6-abe2-0f20-337e-e9ee00c883d8@roeck-us.net> <20170124175800.GA15070@amd> <20170124184526.GA25056@roeck-us.net> <20170125111233.GB3912@amd> <20170125120918.GA7936@pali> <1485481030.2469.15.camel@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AhhlLboLdkugWU4S" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --AhhlLboLdkugWU4S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > >If this is the case, you'd better set > >(struct thermal_zone_params)->no_hwmon when registering the thermal > >zone device, in which case, the hwmon device will not be created. > > > >In fact, I'd prefer to change tzp->no_hwmon to tzp->hwmon to not create > >hwmon I/F by default, and see if there is anyone using it. If yes, we > >can set the flag in soc thermal driver, explicitly, at meantime, a > >hwmon compatible name is required. > > > >But one foreseeable result is that we may get bug reports from end user > >that some sensors (acpitz, etc) are gone in 'sensors' output. And TBH, > >I'm not quite sure if this can be counted as a regression or not. > > >=20 > That sounds like fun. Changing bq27200-0 to bq27200_0 is Forbidden by > the ABI Police, but taking the entire device away is ok. Stop trying to break other people's systems. Thanks you. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --AhhlLboLdkugWU4S Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAliLKnsACgkQMOfwapXb+vLU/wCcDLC0OEATT+uy5EI/bLzaLKsF mUQAn2UUWxhWk1By8ParVSFpnua9LSPj =mCnF -----END PGP SIGNATURE----- --AhhlLboLdkugWU4S--