From mboxrd@z Thu Jan 1 00:00:00 1970 From: Corentin Labbe Subject: Re: [PATCH] Net: ethernet: mediatek - Fix possible NULL derefrence. Date: Fri, 27 Jan 2017 13:44:49 +0100 Message-ID: <20170127124449.GB13611@Red> References: <1485515980-3814-1-git-send-email-shailendra.v@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1485515980-3814-1-git-send-email-shailendra.v-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Shailendra Verma Cc: Felix Fietkau , ashish.kalra-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, p.shailesh-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Matthias Brugger , Shailendra Verma , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, John Crispin List-Id: linux-mediatek@lists.infradead.org On Fri, Jan 27, 2017 at 04:49:40PM +0530, Shailendra Verma wrote: > of_match_device could return NULL, and so can cause a NULL > pointer dereference later. > > Signed-off-by: Shailendra Verma > --- > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > index 4a62ffd..4495b7b 100644 > --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c > +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > @@ -2369,6 +2369,10 @@ static int mtk_probe(struct platform_device *pdev) > int i; > > match = of_match_device(of_mtk_match, &pdev->dev); > + if (!match) { > + dev_err(&pdev->dev, "Error: No device match found\n"); > + return -ENODEV; > + } > soc = (struct mtk_soc_data *)match->data; > > eth = devm_kzalloc(&pdev->dev, sizeof(*eth), GFP_KERNEL); > -- Hello You could use of_device_get_match_data() and simplifiy code Regards Corentin Labbe From mboxrd@z Thu Jan 1 00:00:00 1970 From: clabbe.montjoie@gmail.com (Corentin Labbe) Date: Fri, 27 Jan 2017 13:44:49 +0100 Subject: [PATCH] Net: ethernet: mediatek - Fix possible NULL derefrence. In-Reply-To: <1485515980-3814-1-git-send-email-shailendra.v@samsung.com> References: <1485515980-3814-1-git-send-email-shailendra.v@samsung.com> Message-ID: <20170127124449.GB13611@Red> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Jan 27, 2017 at 04:49:40PM +0530, Shailendra Verma wrote: > of_match_device could return NULL, and so can cause a NULL > pointer dereference later. > > Signed-off-by: Shailendra Verma > --- > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > index 4a62ffd..4495b7b 100644 > --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c > +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > @@ -2369,6 +2369,10 @@ static int mtk_probe(struct platform_device *pdev) > int i; > > match = of_match_device(of_mtk_match, &pdev->dev); > + if (!match) { > + dev_err(&pdev->dev, "Error: No device match found\n"); > + return -ENODEV; > + } > soc = (struct mtk_soc_data *)match->data; > > eth = devm_kzalloc(&pdev->dev, sizeof(*eth), GFP_KERNEL); > -- Hello You could use of_device_get_match_data() and simplifiy code Regards Corentin Labbe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932483AbdA0MyA (ORCPT ); Fri, 27 Jan 2017 07:54:00 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:36186 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754417AbdA0Mxz (ORCPT ); Fri, 27 Jan 2017 07:53:55 -0500 Date: Fri, 27 Jan 2017 13:44:49 +0100 From: Corentin Labbe To: Shailendra Verma Cc: Felix Fietkau , John Crispin , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, p.shailesh@samsung.com, ashish.kalra@samsung.com, Shailendra Verma Subject: Re: [PATCH] Net: ethernet: mediatek - Fix possible NULL derefrence. Message-ID: <20170127124449.GB13611@Red> References: <1485515980-3814-1-git-send-email-shailendra.v@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1485515980-3814-1-git-send-email-shailendra.v@samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 27, 2017 at 04:49:40PM +0530, Shailendra Verma wrote: > of_match_device could return NULL, and so can cause a NULL > pointer dereference later. > > Signed-off-by: Shailendra Verma > --- > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > index 4a62ffd..4495b7b 100644 > --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c > +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > @@ -2369,6 +2369,10 @@ static int mtk_probe(struct platform_device *pdev) > int i; > > match = of_match_device(of_mtk_match, &pdev->dev); > + if (!match) { > + dev_err(&pdev->dev, "Error: No device match found\n"); > + return -ENODEV; > + } > soc = (struct mtk_soc_data *)match->data; > > eth = devm_kzalloc(&pdev->dev, sizeof(*eth), GFP_KERNEL); > -- Hello You could use of_device_get_match_data() and simplifiy code Regards Corentin Labbe