From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH] tpm: fix RC value check in tpm2_seal_trusted Date: Fri, 27 Jan 2017 09:24:16 -0700 Message-ID: <20170127162416.GA32330@obsidianresearch.com> References: <20170125210348.13790-1-jarkko.sakkinen@linux.intel.com> <20170125221245.GB713@obsidianresearch.com> <20170126112714.xvvvb72dybmfgitw@intel.com> <20170126183252.GA16502@obsidianresearch.com> <20170127064327.esussb6itanaqibq@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20170127064327.esussb6itanaqibq-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tpmdd-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jarkko Sakkinen Cc: linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, open list List-Id: tpmdd-devel@lists.sourceforge.net On Fri, Jan 27, 2017 at 08:43:27AM +0200, Jarkko Sakkinen wrote: > On Thu, Jan 26, 2017 at 11:32:52AM -0700, Jason Gunthorpe wrote: > > On Thu, Jan 26, 2017 at 01:27:14PM +0200, Jarkko Sakkinen wrote: > > > > > "The error code handling is bogus as any error code that has the bits > > > set that TPM_RC_HASH could pass. Implemented tpm2_rc_value() helper to > > > parse the error value from FMT0 and FMT1 error codes to use to check the > > > error so that these types of mistakes is prevented in the future." > > > > Great thanks > > > > Jason > > Can I put your Reviewed-by? I would like to get this into 4.11. I'm not up to speed on the TPM2 parsing, but it looks OK based on your description. Reviewed-by: Jason Gunthorpe Jason ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933008AbdA0Q1W (ORCPT ); Fri, 27 Jan 2017 11:27:22 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:37559 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754735AbdA0Q0q (ORCPT ); Fri, 27 Jan 2017 11:26:46 -0500 Date: Fri, 27 Jan 2017 09:24:16 -0700 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: tpmdd-devel@lists.sourceforge.net, linux-security-module@vger.kernel.org, Peter Huewe , Marcel Selhorst , open list Subject: Re: [PATCH] tpm: fix RC value check in tpm2_seal_trusted Message-ID: <20170127162416.GA32330@obsidianresearch.com> References: <20170125210348.13790-1-jarkko.sakkinen@linux.intel.com> <20170125221245.GB713@obsidianresearch.com> <20170126112714.xvvvb72dybmfgitw@intel.com> <20170126183252.GA16502@obsidianresearch.com> <20170127064327.esussb6itanaqibq@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170127064327.esussb6itanaqibq@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 27, 2017 at 08:43:27AM +0200, Jarkko Sakkinen wrote: > On Thu, Jan 26, 2017 at 11:32:52AM -0700, Jason Gunthorpe wrote: > > On Thu, Jan 26, 2017 at 01:27:14PM +0200, Jarkko Sakkinen wrote: > > > > > "The error code handling is bogus as any error code that has the bits > > > set that TPM_RC_HASH could pass. Implemented tpm2_rc_value() helper to > > > parse the error value from FMT0 and FMT1 error codes to use to check the > > > error so that these types of mistakes is prevented in the future." > > > > Great thanks > > > > Jason > > Can I put your Reviewed-by? I would like to get this into 4.11. I'm not up to speed on the TPM2 parsing, but it looks OK based on your description. Reviewed-by: Jason Gunthorpe Jason