All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: DongOh Shin <doscode.kr@gmail.com>
Cc: linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH 0/5] Fix coding style errors and warnings in f2fs.h
Date: Sun, 29 Jan 2017 13:23:42 +0900	[thread overview]
Message-ID: <20170129042342.GD65555@jaegeuk.local> (raw)
In-Reply-To: <20170127182940.11389-1-doscode.kr@gmail.com>

Hi DongOh,

It doesn't need to split everything with same patch subjects. So, could
you please submit two patches?
- f2fs: fix coding style errors in f2fs.h
- f2fs: fix coding style warnings in f2fs.h

Thanks,

On 01/27, DongOh Shin wrote:
> f2fs.h has 3 errors and 454 warnings on the coding style.
> This series of patches resolve 3 errors and 446 warnings below:
> 0001, error,   "Macros with complex values should be enclosed in parentheses"
> 0002, error,   "space prohibited before that ',' (ctx:WxW)"
> 0003, warning, "Missing a blank line after declarations"
> 0004, warning, "function definition argument 'x' should also have an identifier name"
> 0005, warning, "macros should not use a trailing semicolon"
> 
> So, after applying this patch, it is reduced to 8 warnings only.
> 
> DongOh Shin (5):
>   Fix coding style errors in f2fs.h
>   Fix coding style error in f2fs.h
>   Fix coding style warnings in f2fs.h
>   Fix coding style warnings in f2fs.h
>   Fix coding style warnings in f2fs.h
> 
>  fs/f2fs/f2fs.h | 502 +++++++++++++++++++++++++++++++--------------------------
>  1 file changed, 272 insertions(+), 230 deletions(-)
> 
> -- 
> 1.8.3.1
> 
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot

      parent reply	other threads:[~2017-01-29  4:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-27 18:29 [PATCH 0/5] Fix coding style errors and warnings in f2fs.h DongOh Shin
2017-01-27 18:29 ` [PATCH 1/5] Fix coding style errors " DongOh Shin
2017-01-27 18:29 ` [PATCH 2/5] Fix coding style error " DongOh Shin
2017-01-27 18:29 ` [PATCH 3/5] Fix coding style warnings " DongOh Shin
2017-01-27 18:29 ` [PATCH 4/5] " DongOh Shin
2017-01-27 18:29 ` [PATCH 5/5] " DongOh Shin
2017-01-29  4:23 ` Jaegeuk Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170129042342.GD65555@jaegeuk.local \
    --to=jaegeuk@kernel.org \
    --cc=doscode.kr@gmail.com \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.