From: Davidlohr Bueso <dave@stgolabs.net>
To: hpa@zytor.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, tglx@linutronix.de,
paulmck@linux.vnet.ibm.com, longman@redhat.com, mingo@kernel.org,
peterz@infradead.org, torvalds@linux-foundation.org
Cc: linux-tip-commits@vger.kernel.org
Subject: [PATCH -tip] sched/wake_q: Clarify queue reinit
Date: Sun, 29 Jan 2017 07:15:31 -0800 [thread overview]
Message-ID: <20170129151531.GA2444@linux-80c1.suse> (raw)
In-Reply-To: <tip-bcc9a76d5ac426bc45c9e863b1830347827ca77a@git.kernel.org>
As of bcc9a76d5ac (locking/rwsem: Reinit wake_q after use), the
comment regarding the list reinitialization no longer applies,
update it with the new wake_q_init() helper.
Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
---
include/linux/sched.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 3640bde9f982..c0bc626c531f 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -998,8 +998,8 @@ enum cpu_idle_type {
*
* The DEFINE_WAKE_Q macro declares and initializes the list head.
* wake_up_q() does NOT reinitialize the list; it's expected to be
- * called near the end of a function, where the fact that the queue is
- * not used again will be easy to see by inspection.
+ * called near the end of a function. Otherwise, the list can be
+ * re-initialized for later re-use by wake_q_init().
*
* Note that this can cause spurious wakeups. schedule() callers
* must ensure the call is done inside a loop, confirming that the
--
2.6.6
next prev parent reply other threads:[~2017-01-29 15:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-22 2:33 [PATCH] locking/rwsem: Reinit wake_q after use Waiman Long
2017-01-22 10:14 ` [tip:locking/core] " tip-bot for Waiman Long
2017-01-29 15:15 ` Davidlohr Bueso [this message]
2017-01-29 16:22 ` [PATCH -tip] sched/wake_q: Clarify queue reinit Waiman Long
2017-02-01 10:08 ` [tip:locking/core] sched/wake_q: Clarify queue reinit comment tip-bot for Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170129151531.GA2444@linux-80c1.suse \
--to=dave@stgolabs.net \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.