From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH v3 08/24] drm/rockchip: dw-mipi-dsi: respect message flags Date: Mon, 30 Jan 2017 13:19:22 -0500 Message-ID: <20170130181922.GI20076@art_vandelay> References: <20170129132444.25251-1-john@metanate.com> <20170129132444.25251-9-john@metanate.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170129132444.25251-9-john@metanate.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Keeping Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Chris Zhong , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gU3VuLCBKYW4gMjksIDIwMTcgYXQgMDE6MjQ6MjhQTSArMDAwMCwgSm9obiBLZWVwaW5nIHdy b3RlOgo+IEluc3RlYWQgb2YgYWx3YXlzIHNlbmRpbmcgY29tbWFuZHMgaW4gTFAgbW9kZSwgcmVz cGVjdCB0aGUKPiBNSVBJX0RTSV9NU0dfVVNFX0xQTSBmbGFnIHRvIGRlY2lkZSBob3cgdG8gc2Vu ZCBlYWNoIG1lc3NhZ2UuICBBbHNvCj4gcmVxdWVzdCBhY2tzIGlmIE1JUElfRFNJX01TR19SRVFf QUNLIGlzIHNldC4KPiAKClJldmlld2VkLWJ5OiBTZWFuIFBhdWwgPHNlYW5wYXVsQGNocm9taXVt Lm9yZz4KCj4gU2lnbmVkLW9mZi1ieTogSm9obiBLZWVwaW5nIDxqb2huQG1ldGFuYXRlLmNvbT4K PiBSZXZpZXdlZC1ieTogQ2hyaXMgWmhvbmcgPHp5d0Byb2NrLWNoaXBzLmNvbT4KPiAtLS0KPiB2 MzoKPiAtIEFkZCBDaHJpcycgUmV2aWV3ZWQtYnkKPiBVbmNoYW5nZWQgaW4gdjIKPiAKPiAgZHJp dmVycy9ncHUvZHJtL3JvY2tjaGlwL2R3LW1pcGktZHNpLmMgfCAxNiArKysrKysrKysrKysrKyst Cj4gIDEgZmlsZSBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9kdy1taXBpLWRzaS5jIGIvZHJp dmVycy9ncHUvZHJtL3JvY2tjaGlwL2R3LW1pcGktZHNpLmMKPiBpbmRleCA5MmRiYzNlNTY2MDMu LjE1ZDMzYzNjOGNiNyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvZHct bWlwaS1kc2kuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9kdy1taXBpLWRzaS5j Cj4gQEAgLTU0Miw2ICs1NDIsMTkgQEAgc3RhdGljIGludCBkd19taXBpX2RzaV9ob3N0X2RldGFj aChzdHJ1Y3QgbWlwaV9kc2lfaG9zdCAqaG9zdCwKPiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+ICtz dGF0aWMgdm9pZCBkd19taXBpX21lc3NhZ2VfY29uZmlnKHN0cnVjdCBkd19taXBpX2RzaSAqZHNp LAo+ICsJCQkJICAgY29uc3Qgc3RydWN0IG1pcGlfZHNpX21zZyAqbXNnKQo+ICt7Cj4gKwl1MzIg dmFsID0gMDsKPiArCj4gKwlpZiAobXNnLT5mbGFncyAmIE1JUElfRFNJX01TR19SRVFfQUNLKQo+ ICsJCXZhbCB8PSBFTl9BQ0tfUlFTVDsKPiArCWlmIChtc2ctPmZsYWdzICYgTUlQSV9EU0lfTVNH X1VTRV9MUE0pCj4gKwkJdmFsIHw9IENNRF9NT0RFX0FMTF9MUDsKPiArCj4gKwlkc2lfd3JpdGUo ZHNpLCBEU0lfQ01EX01PREVfQ0ZHLCB2YWwpOwo+ICt9Cj4gKwo+ICBzdGF0aWMgaW50IGR3X21p cGlfZHNpX2dlbl9wa3RfaGRyX3dyaXRlKHN0cnVjdCBkd19taXBpX2RzaSAqZHNpLCB1MzIgaGRy X3ZhbCkKPiAgewo+ICAJaW50IHJldDsKPiBAQCAtNjM0LDYgKzY0Nyw4IEBAIHN0YXRpYyBzc2l6 ZV90IGR3X21pcGlfZHNpX2hvc3RfdHJhbnNmZXIoc3RydWN0IG1pcGlfZHNpX2hvc3QgKmhvc3Qs Cj4gIAlzdHJ1Y3QgZHdfbWlwaV9kc2kgKmRzaSA9IGhvc3RfdG9fZHNpKGhvc3QpOwo+ICAJaW50 IHJldDsKPiAgCj4gKwlkd19taXBpX21lc3NhZ2VfY29uZmlnKGRzaSwgbXNnKTsKPiArCj4gIAlz d2l0Y2ggKG1zZy0+dHlwZSkgewo+ICAJY2FzZSBNSVBJX0RTSV9EQ1NfU0hPUlRfV1JJVEU6Cj4g IAljYXNlIE1JUElfRFNJX0RDU19TSE9SVF9XUklURV9QQVJBTToKPiBAQCAtNzQ1LDcgKzc2MCw2 IEBAIHN0YXRpYyB2b2lkIGR3X21pcGlfZHNpX2NvbW1hbmRfbW9kZV9jb25maWcoc3RydWN0IGR3 X21pcGlfZHNpICpkc2kpCj4gIHsKPiAgCWRzaV93cml0ZShkc2ksIERTSV9UT19DTlRfQ0ZHLCBI U1RYX1RPX0NOVCgxMDAwKSB8IExQUlhfVE9fQ05UKDEwMDApKTsKPiAgCWRzaV93cml0ZShkc2ks IERTSV9CVEFfVE9fQ05ULCAweGQwMCk7Cj4gLQlkc2lfd3JpdGUoZHNpLCBEU0lfQ01EX01PREVf Q0ZHLCBDTURfTU9ERV9BTExfTFApOwo+ICAJZHNpX3dyaXRlKGRzaSwgRFNJX01PREVfQ0ZHLCBF TkFCTEVfQ01EX01PREUpOwo+ICB9Cj4gIAo+IC0tIAo+IDIuMTEuMC4xOTcuZ2I1NTZkZTUuZGly dHkKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwKCi0tIApTZWFuIFBhdWwsIFNvZnR3YXJlIEVuZ2luZWVyLCBHb29nbGUgLyBDaHJvbWl1bSBP UwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: seanpaul@chromium.org (Sean Paul) Date: Mon, 30 Jan 2017 13:19:22 -0500 Subject: [PATCH v3 08/24] drm/rockchip: dw-mipi-dsi: respect message flags In-Reply-To: <20170129132444.25251-9-john@metanate.com> References: <20170129132444.25251-1-john@metanate.com> <20170129132444.25251-9-john@metanate.com> Message-ID: <20170130181922.GI20076@art_vandelay> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, Jan 29, 2017 at 01:24:28PM +0000, John Keeping wrote: > Instead of always sending commands in LP mode, respect the > MIPI_DSI_MSG_USE_LPM flag to decide how to send each message. Also > request acks if MIPI_DSI_MSG_REQ_ACK is set. > Reviewed-by: Sean Paul > Signed-off-by: John Keeping > Reviewed-by: Chris Zhong > --- > v3: > - Add Chris' Reviewed-by > Unchanged in v2 > > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > index 92dbc3e56603..15d33c3c8cb7 100644 > --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > @@ -542,6 +542,19 @@ static int dw_mipi_dsi_host_detach(struct mipi_dsi_host *host, > return 0; > } > > +static void dw_mipi_message_config(struct dw_mipi_dsi *dsi, > + const struct mipi_dsi_msg *msg) > +{ > + u32 val = 0; > + > + if (msg->flags & MIPI_DSI_MSG_REQ_ACK) > + val |= EN_ACK_RQST; > + if (msg->flags & MIPI_DSI_MSG_USE_LPM) > + val |= CMD_MODE_ALL_LP; > + > + dsi_write(dsi, DSI_CMD_MODE_CFG, val); > +} > + > static int dw_mipi_dsi_gen_pkt_hdr_write(struct dw_mipi_dsi *dsi, u32 hdr_val) > { > int ret; > @@ -634,6 +647,8 @@ static ssize_t dw_mipi_dsi_host_transfer(struct mipi_dsi_host *host, > struct dw_mipi_dsi *dsi = host_to_dsi(host); > int ret; > > + dw_mipi_message_config(dsi, msg); > + > switch (msg->type) { > case MIPI_DSI_DCS_SHORT_WRITE: > case MIPI_DSI_DCS_SHORT_WRITE_PARAM: > @@ -745,7 +760,6 @@ static void dw_mipi_dsi_command_mode_config(struct dw_mipi_dsi *dsi) > { > dsi_write(dsi, DSI_TO_CNT_CFG, HSTX_TO_CNT(1000) | LPRX_TO_CNT(1000)); > dsi_write(dsi, DSI_BTA_TO_CNT, 0xd00); > - dsi_write(dsi, DSI_CMD_MODE_CFG, CMD_MODE_ALL_LP); > dsi_write(dsi, DSI_MODE_CFG, ENABLE_CMD_MODE); > } > > -- > 2.11.0.197.gb556de5.dirty > > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754060AbdA3ST1 (ORCPT ); Mon, 30 Jan 2017 13:19:27 -0500 Received: from mail-qt0-f169.google.com ([209.85.216.169]:33427 "EHLO mail-qt0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753605AbdA3STZ (ORCPT ); Mon, 30 Jan 2017 13:19:25 -0500 Date: Mon, 30 Jan 2017 13:19:22 -0500 From: Sean Paul To: John Keeping Cc: Mark Yao , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Chris Zhong , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 08/24] drm/rockchip: dw-mipi-dsi: respect message flags Message-ID: <20170130181922.GI20076@art_vandelay> References: <20170129132444.25251-1-john@metanate.com> <20170129132444.25251-9-john@metanate.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170129132444.25251-9-john@metanate.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 29, 2017 at 01:24:28PM +0000, John Keeping wrote: > Instead of always sending commands in LP mode, respect the > MIPI_DSI_MSG_USE_LPM flag to decide how to send each message. Also > request acks if MIPI_DSI_MSG_REQ_ACK is set. > Reviewed-by: Sean Paul > Signed-off-by: John Keeping > Reviewed-by: Chris Zhong > --- > v3: > - Add Chris' Reviewed-by > Unchanged in v2 > > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > index 92dbc3e56603..15d33c3c8cb7 100644 > --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > @@ -542,6 +542,19 @@ static int dw_mipi_dsi_host_detach(struct mipi_dsi_host *host, > return 0; > } > > +static void dw_mipi_message_config(struct dw_mipi_dsi *dsi, > + const struct mipi_dsi_msg *msg) > +{ > + u32 val = 0; > + > + if (msg->flags & MIPI_DSI_MSG_REQ_ACK) > + val |= EN_ACK_RQST; > + if (msg->flags & MIPI_DSI_MSG_USE_LPM) > + val |= CMD_MODE_ALL_LP; > + > + dsi_write(dsi, DSI_CMD_MODE_CFG, val); > +} > + > static int dw_mipi_dsi_gen_pkt_hdr_write(struct dw_mipi_dsi *dsi, u32 hdr_val) > { > int ret; > @@ -634,6 +647,8 @@ static ssize_t dw_mipi_dsi_host_transfer(struct mipi_dsi_host *host, > struct dw_mipi_dsi *dsi = host_to_dsi(host); > int ret; > > + dw_mipi_message_config(dsi, msg); > + > switch (msg->type) { > case MIPI_DSI_DCS_SHORT_WRITE: > case MIPI_DSI_DCS_SHORT_WRITE_PARAM: > @@ -745,7 +760,6 @@ static void dw_mipi_dsi_command_mode_config(struct dw_mipi_dsi *dsi) > { > dsi_write(dsi, DSI_TO_CNT_CFG, HSTX_TO_CNT(1000) | LPRX_TO_CNT(1000)); > dsi_write(dsi, DSI_BTA_TO_CNT, 0xd00); > - dsi_write(dsi, DSI_CMD_MODE_CFG, CMD_MODE_ALL_LP); > dsi_write(dsi, DSI_MODE_CFG, ENABLE_CMD_MODE); > } > > -- > 2.11.0.197.gb556de5.dirty > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS