From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH v3 11/24] drm/rockchip: dw-mipi-dsi: prepare panel after phy init Date: Mon, 30 Jan 2017 15:16:56 -0500 Message-ID: <20170130201656.GN20076@art_vandelay> References: <20170129132444.25251-1-john@metanate.com> <20170129132444.25251-12-john@metanate.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170129132444.25251-12-john@metanate.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Keeping Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Chris Zhong , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org T24gU3VuLCBKYW4gMjksIDIwMTcgYXQgMDE6MjQ6MzFQTSArMDAwMCwgSm9obiBLZWVwaW5nIHdy b3RlOgo+IFNvbWUgcGFuZWxzIG5lZWQgdG8gYmUgY29uZmlndXJlZCB3aXRoIGNvbW1hbmRzIHNl bnQgb3ZlciB0aGUgTUlQSSBsaW5rLAo+IHdoaWNoIHRoZXkgd2lsbCBkbyBpbiB0aGUgcHJlcGFy ZSBob29rLiAgQ2FsbCB0aGlzIGFmdGVyIHRoZSBQSFkgaGFzCj4gYmVlbiBpbml0aWFsaXplZCBz byB0aGF0IHdlIGFyZSBhYmxlIHRvIHNlbmQgY29tbWFuZHMgdG8gdGhlIHBhbmVsLgo+IAoKUmV2 aWV3ZWQtYnk6IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgoKPiBTaWduZWQtb2Zm LWJ5OiBKb2huIEtlZXBpbmcgPGpvaG5AbWV0YW5hdGUuY29tPgo+IFJldmlld2VkLWJ5OiBDaHJp cyBaaG9uZyA8enl3QHJvY2stY2hpcHMuY29tPgo+IC0tLQo+IHYzOgo+IC0gQWRkIENocmlzJyBS ZXZpZXdlZC1ieQo+IFVuY2hhbmdlZCBpbiB2Mgo+IAo+ICBkcml2ZXJzL2dwdS9kcm0vcm9ja2No aXAvZHctbWlwaS1kc2kuYyB8IDYgKysrKy0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlv bnMoKyksIDIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9y b2NrY2hpcC9kdy1taXBpLWRzaS5jIGIvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL2R3LW1pcGkt ZHNpLmMKPiBpbmRleCBkZGJjMDM3ZTdjZWQuLjdhZGE2ZDhlZDE0MyAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvZHctbWlwaS1kc2kuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9yb2NrY2hpcC9kdy1taXBpLWRzaS5jCj4gQEAgLTg5NiwxMiArODk2LDE0IEBAIHN0YXRp YyB2b2lkIGR3X21pcGlfZHNpX2VuY29kZXJfZW5hYmxlKHN0cnVjdCBkcm1fZW5jb2RlciAqZW5j b2RlcikKPiAgCWR3X21pcGlfZHNpX2RwaHlfdGltaW5nX2NvbmZpZyhkc2kpOwo+ICAJZHdfbWlw aV9kc2lfZHBoeV9pbnRlcmZhY2VfY29uZmlnKGRzaSk7Cj4gIAlkd19taXBpX2RzaV9jbGVhcl9l cnIoZHNpKTsKPiAtCWlmIChkcm1fcGFuZWxfcHJlcGFyZShkc2ktPnBhbmVsKSkKPiAtCQlkZXZf ZXJyKGRzaS0+ZGV2LCAiZmFpbGVkIHRvIHByZXBhcmUgcGFuZWxcbiIpOwo+ICAKPiAgCWR3X21p cGlfZHNpX3BoeV9pbml0KGRzaSk7Cj4gIAlkd19taXBpX2RzaV93YWl0X2Zvcl90d29fZnJhbWVz KG1vZGUpOwo+ICAKPiArCWR3X21pcGlfZHNpX3NldF9tb2RlKGRzaSwgRFdfTUlQSV9EU0lfQ01E X01PREUpOwo+ICsJaWYgKGRybV9wYW5lbF9wcmVwYXJlKGRzaS0+cGFuZWwpKQo+ICsJCWRldl9l cnIoZHNpLT5kZXYsICJmYWlsZWQgdG8gcHJlcGFyZSBwYW5lbFxuIik7Cj4gKwo+ICAJZHdfbWlw aV9kc2lfc2V0X21vZGUoZHNpLCBEV19NSVBJX0RTSV9WSURfTU9ERSk7Cj4gIAlkcm1fcGFuZWxf ZW5hYmxlKGRzaS0+cGFuZWwpOwo+ICAKPiAtLSAKPiAyLjExLjAuMTk3LmdiNTU2ZGU1LmRpcnR5 Cj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBk cmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs CgotLSAKU2VhbiBQYXVsLCBTb2Z0d2FyZSBFbmdpbmVlciwgR29vZ2xlIC8gQ2hyb21pdW0gT1MK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: seanpaul@chromium.org (Sean Paul) Date: Mon, 30 Jan 2017 15:16:56 -0500 Subject: [PATCH v3 11/24] drm/rockchip: dw-mipi-dsi: prepare panel after phy init In-Reply-To: <20170129132444.25251-12-john@metanate.com> References: <20170129132444.25251-1-john@metanate.com> <20170129132444.25251-12-john@metanate.com> Message-ID: <20170130201656.GN20076@art_vandelay> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, Jan 29, 2017 at 01:24:31PM +0000, John Keeping wrote: > Some panels need to be configured with commands sent over the MIPI link, > which they will do in the prepare hook. Call this after the PHY has > been initialized so that we are able to send commands to the panel. > Reviewed-by: Sean Paul > Signed-off-by: John Keeping > Reviewed-by: Chris Zhong > --- > v3: > - Add Chris' Reviewed-by > Unchanged in v2 > > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > index ddbc037e7ced..7ada6d8ed143 100644 > --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > @@ -896,12 +896,14 @@ static void dw_mipi_dsi_encoder_enable(struct drm_encoder *encoder) > dw_mipi_dsi_dphy_timing_config(dsi); > dw_mipi_dsi_dphy_interface_config(dsi); > dw_mipi_dsi_clear_err(dsi); > - if (drm_panel_prepare(dsi->panel)) > - dev_err(dsi->dev, "failed to prepare panel\n"); > > dw_mipi_dsi_phy_init(dsi); > dw_mipi_dsi_wait_for_two_frames(mode); > > + dw_mipi_dsi_set_mode(dsi, DW_MIPI_DSI_CMD_MODE); > + if (drm_panel_prepare(dsi->panel)) > + dev_err(dsi->dev, "failed to prepare panel\n"); > + > dw_mipi_dsi_set_mode(dsi, DW_MIPI_DSI_VID_MODE); > drm_panel_enable(dsi->panel); > > -- > 2.11.0.197.gb556de5.dirty > > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754399AbdA3URL (ORCPT ); Mon, 30 Jan 2017 15:17:11 -0500 Received: from mail-qt0-f179.google.com ([209.85.216.179]:36136 "EHLO mail-qt0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754369AbdA3URJ (ORCPT ); Mon, 30 Jan 2017 15:17:09 -0500 Date: Mon, 30 Jan 2017 15:16:56 -0500 From: Sean Paul To: John Keeping Cc: Mark Yao , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Chris Zhong , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 11/24] drm/rockchip: dw-mipi-dsi: prepare panel after phy init Message-ID: <20170130201656.GN20076@art_vandelay> References: <20170129132444.25251-1-john@metanate.com> <20170129132444.25251-12-john@metanate.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170129132444.25251-12-john@metanate.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 29, 2017 at 01:24:31PM +0000, John Keeping wrote: > Some panels need to be configured with commands sent over the MIPI link, > which they will do in the prepare hook. Call this after the PHY has > been initialized so that we are able to send commands to the panel. > Reviewed-by: Sean Paul > Signed-off-by: John Keeping > Reviewed-by: Chris Zhong > --- > v3: > - Add Chris' Reviewed-by > Unchanged in v2 > > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > index ddbc037e7ced..7ada6d8ed143 100644 > --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > @@ -896,12 +896,14 @@ static void dw_mipi_dsi_encoder_enable(struct drm_encoder *encoder) > dw_mipi_dsi_dphy_timing_config(dsi); > dw_mipi_dsi_dphy_interface_config(dsi); > dw_mipi_dsi_clear_err(dsi); > - if (drm_panel_prepare(dsi->panel)) > - dev_err(dsi->dev, "failed to prepare panel\n"); > > dw_mipi_dsi_phy_init(dsi); > dw_mipi_dsi_wait_for_two_frames(mode); > > + dw_mipi_dsi_set_mode(dsi, DW_MIPI_DSI_CMD_MODE); > + if (drm_panel_prepare(dsi->panel)) > + dev_err(dsi->dev, "failed to prepare panel\n"); > + > dw_mipi_dsi_set_mode(dsi, DW_MIPI_DSI_VID_MODE); > drm_panel_enable(dsi->panel); > > -- > 2.11.0.197.gb556de5.dirty > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS