From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [bug report] IB/cma: Add default RoCE TOS to CMA configfs
Date: Tue, 31 Jan 2017 13:59:29 +0300 [thread overview]
Message-ID: <20170131105929.GA6788@mwanda> (raw)
Hello Majd Dibbiny,
The patch eeec11e5c404: "IB/cma: Add default RoCE TOS to CMA
configfs" from Dec 19, 2016, leads to the following static checker
warning:
drivers/infiniband/core/cma.c:303 cma_get_default_roce_tos()
warn: signedness bug returning '(-22)'
drivers/infiniband/core/cma.c
298
299 u8 cma_get_default_roce_tos(struct cma_device *cma_dev, unsigned int port)
300 {
301 if (port < rdma_start_port(cma_dev->device) ||
302 port > rdma_end_port(cma_dev->device))
303 return -EINVAL;
This is a u8 function so you can't return negative error codes.
304
305 return cma_dev->default_roce_tos[port - rdma_start_port(cma_dev->device)];
306 }
307
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2017-01-31 10:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 10:59 Dan Carpenter [this message]
2017-01-31 15:32 ` [bug report] IB/cma: Add default RoCE TOS to CMA configfs Majd Dibbiny
[not found] ` <01D1013C-F14B-467D-A21E-9EA6214A38F5-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-01-31 16:02 ` Yuval Shaia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170131105929.GA6788@mwanda \
--to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.