All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olivier Matz <olivier.matz@6wind.com>
To: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>, <dev@dpdk.org>
Subject: Re: [PATCH] mbuf: use pktmbuf helper to create the pool
Date: Tue, 31 Jan 2017 11:32:04 +0100	[thread overview]
Message-ID: <20170131113204.5d3b3df2@platinum> (raw)
In-Reply-To: <20170117133121.GA27592@santosh-Latitude-E5530-non-vPro>

Hi Santosh,

On Tue, 17 Jan 2017 19:01:23 +0530, Santosh Shukla
<santosh.shukla@caviumnetworks.com> wrote:
> Hi Hemant,
> 
> On Wed, Jan 18, 2017 at 12:12:56AM +0530, Hemant Agrawal wrote:
> > When possible, replace the uses of rte_mempool_create() with
> > the helper provided in librte_mbuf: rte_pktmbuf_pool_create().
> > 
> > This is the preferred way to create a mbuf pool.
> > 
> > This also updates the documentation.  
> 
> 
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > ---
> > This patch is derived from the RFC from Olivier:
> > http://dpdk.org/dev/patchwork/patch/15925/  
> 
> rte_mempool_create to _empty/populate OR rte_pktmbuf_pool_create
> changes missing for mempool testcases. do you have plan to take them
> up Or shall I post the patches? 

Not sure we should add something in test_mempool.c, since we are
converting to a mbuf api. As far as I can see,
rte_pktmbuf_pool_create() is already tested in test_mbuf.c.


Regards,
Olivier

  parent reply	other threads:[~2017-01-31 10:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-17 18:42 [PATCH] mbuf: use pktmbuf helper to create the pool Hemant Agrawal
2017-01-17 13:31 ` Santosh Shukla
2017-01-18  6:01   ` Hemant Agrawal
2017-01-31 10:32   ` Olivier Matz [this message]
2017-01-20  7:11 ` [PATCH v2] " Hemant Agrawal
2017-01-31  9:55   ` Olivier Matz
2017-02-01 19:31     ` Hemant Agrawal
2017-02-14 22:00   ` [PATCH v3] " Hemant Agrawal
2017-03-14  9:14     ` [PATCH v4] " Olivier Matz
2017-03-15 12:57       ` Thomas Monjalon
  -- strict thread matches above, loose matches on Subject: below --
2017-01-17 18:52 [PATCHv4 00/33] NXP DPAA2 PMD Hemant Agrawal
2017-01-19 13:23 ` [PATCHv5 " Hemant Agrawal
2017-01-19 13:23   ` [PATCH] mbuf: use pktmbuf helper to create the pool Hemant Agrawal
2017-01-19 13:27     ` Hemant Agrawal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170131113204.5d3b3df2@platinum \
    --to=olivier.matz@6wind.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=santosh.shukla@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.