From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752238AbdAaNP3 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 31 Jan 2017 08:15:29 -0500
Received: from mail.kernel.org ([198.145.29.136]:59506 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752042AbdAaNPV (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 31 Jan 2017 08:15:21 -0500
Date: Tue, 31 Jan 2017 10:15:09 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Taeung Song <treeze.taeung@gmail.com>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Wang Nan <wangnan0@huawei.com>
Subject: Re: [PATCH v2 2/4] perf ftrace: Add ftrace.tracer config option
Message-ID: <20170131131509.GD4491@kernel.org>
References: <1485862711-20216-1-git-send-email-treeze.taeung@gmail.com>
 <1485862711-20216-3-git-send-email-treeze.taeung@gmail.com>
 <20170131124628.GC4491@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170131124628.GC4491@kernel.org>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Tue, Jan 31, 2017 at 09:46:28AM -0300, Arnaldo Carvalho de Melo escreveu:
> Also you are silently ignoring any unknown variable in this section, so
> if someone has this:
> 
> cat ~/.perfconfig
> 
> [ftrace]
> 
> 	trace = function
> 
> 
> I.e. forgets the 'r', it will keep using the current default,
> "function_graph" till the user checks the config and adds that missing
> 'r'...
> 
> I haven't changed this because I think this is so common that we should
> instead have a different error return for those config callbacks that
> will tell perf_config() to say something like:
> 
>   "unknown variable %s.%s\n", section_name, variable_name

So I read a bit more the config code and ended up with this:

static int perf_ftrace_config(const char *var, const char *value, void *cb)
{
        struct perf_ftrace *ftrace = cb;

        if (prefixcmp(var, "ftrace."))
                return 0;

        if (strcmp(var, "ftrace.tracer"))
                return -1;

        if (!strcmp(value, "function_graph") ||
            !strcmp(value, "function")) {
                ftrace->tracer = value;
                return 0;
        }

	pr_err("Please select \"function_graph\" (default) or \"function\"\n");
        return -1;
}

I.e. it will ignore variables for other sections and will stop at an unknown
variable or value for ftrace.tracer:

[root@jouet ~]# cat ~/.perfconfig 
[ftrace]
	trace = function
[root@jouet ~]# perf ftrace usleep 1
Error: wrong config key-value pair ftrace.trace=function
[root@jouet ~]# cat ~/.perfconfig 
[ftrace]
	tracer = functin
[root@jouet ~]# perf ftrace usleep 1
Please select "function_graph" (default) or "function"
Error: wrong config key-value pair ftrace.tracer=functin
[root@jouet ~]# cat ~/.perfconfig 
[ftrace]
	tracer = function
[root@jouet ~]# perf ftrace usleep 1 | head -5
          <idle>-0     [000] d...  3855.820847: switch_mm_irqs_off <-__schedule
           <...>-18550 [000] d...  3855.820849: finish_task_switch <-__schedule
           <...>-18550 [000] d...  3855.820851: smp_irq_work_interrupt <-irq_work_interrupt
           <...>-18550 [000] d...  3855.820851: irq_enter <-smp_irq_work_interrupt
           <...>-18550 [000] d...  3855.820851: rcu_irq_enter <-irq_enter
[root@jouet ~]#

- Arnaldo