From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752249AbdAaN0V (ORCPT ); Tue, 31 Jan 2017 08:26:21 -0500 Received: from mail.kernel.org ([198.145.29.136]:34206 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752059AbdAaN0A (ORCPT ); Tue, 31 Jan 2017 08:26:00 -0500 Date: Tue, 31 Jan 2017 10:25:41 -0300 From: Arnaldo Carvalho de Melo To: Taeung Song Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim , Ingo Molnar , Peter Zijlstra , Wang Nan Subject: Re: [PATCH v2 4/4] perf tools: Increase index if perf_evsel__new_idx() succeeded Message-ID: <20170131132541.GF4491@kernel.org> References: <1485862711-20216-1-git-send-email-treeze.taeung@gmail.com> <1485862711-20216-5-git-send-email-treeze.taeung@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1485862711-20216-5-git-send-email-treeze.taeung@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Jan 31, 2017 at 08:38:31PM +0900, Taeung Song escreveu: > Cc: Jiri Olsa > Cc: Namhyung Kim > Signed-off-by: Taeung Song The title of this patch is misleading, ambiguous. It leads one to have doubt if we were not incrementing that index before and now we are, after successfully calling perf_evsel__new_idx(). It should have been: "perf tools: Only increase index if perf_evsel__new_idx() succeeds" - Arnaldo > --- > tools/perf/util/parse-events.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c > index 87a3e5a..ac47c12 100644 > --- a/tools/perf/util/parse-events.c > +++ b/tools/perf/util/parse-events.c > @@ -311,10 +311,11 @@ __add_event(struct list_head *list, int *idx, > > event_attr_init(attr); > > - evsel = perf_evsel__new_idx(attr, (*idx)++); > + evsel = perf_evsel__new_idx(attr, *idx); > if (!evsel) > return NULL; > > + (*idx)++; > evsel->cpus = cpu_map__get(cpus); > evsel->own_cpus = cpu_map__get(cpus); > > -- > 2.7.4