From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
Vinod Koul <vinod.koul@intel.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 3/4] ASoC: Intel: hifi2: Convert write()/write64() to return void
Date: Tue, 31 Jan 2017 16:14:24 +0200 [thread overview]
Message-ID: <20170131141425.35482-3-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20170131141425.35482-1-andriy.shevchenko@linux.intel.com>
There is no point to always return 0.
Convert sst_shim_write() and sst_shim_write64() to return void.
No caller is checking for return value.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
sound/soc/intel/atom/sst/sst.h | 4 ++--
sound/soc/intel/atom/sst/sst_pvt.c | 6 ++----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/sound/soc/intel/atom/sst/sst.h b/sound/soc/intel/atom/sst/sst.h
index c585b07925f8..f00c13d53d23 100644
--- a/sound/soc/intel/atom/sst/sst.h
+++ b/sound/soc/intel/atom/sst/sst.h
@@ -534,9 +534,9 @@ u32 relocate_imr_addr_mrfld(u32 base_addr);
void sst_add_to_dispatch_list_and_post(struct intel_sst_drv *sst,
struct ipc_post *msg);
int sst_pm_runtime_put(struct intel_sst_drv *sst_drv);
-int sst_shim_write(void __iomem *addr, int offset, int value);
+void sst_shim_write(void __iomem *addr, int offset, int value);
u32 sst_shim_read(void __iomem *addr, int offset);
-int sst_shim_write64(void __iomem *addr, int offset, u64 value);
+void sst_shim_write64(void __iomem *addr, int offset, u64 value);
u64 sst_shim_read64(void __iomem *addr, int offset);
void sst_set_fw_state_locked(
struct intel_sst_drv *sst_drv_ctx, int sst_state);
diff --git a/sound/soc/intel/atom/sst/sst_pvt.c b/sound/soc/intel/atom/sst/sst_pvt.c
index 2452cbd77033..00d58f41231a 100644
--- a/sound/soc/intel/atom/sst/sst_pvt.c
+++ b/sound/soc/intel/atom/sst/sst_pvt.c
@@ -39,10 +39,9 @@
#include "sst.h"
#include "../../common/sst-dsp.h"
-int sst_shim_write(void __iomem *addr, int offset, int value)
+void sst_shim_write(void __iomem *addr, int offset, int value)
{
writel(value, addr + offset);
- return 0;
}
u32 sst_shim_read(void __iomem *addr, int offset)
@@ -50,10 +49,9 @@ u32 sst_shim_read(void __iomem *addr, int offset)
return readl(addr + offset);
}
-int sst_shim_write64(void __iomem *addr, int offset, u64 value)
+void sst_shim_write64(void __iomem *addr, int offset, u64 value)
{
lo_hi_writeq(value, addr + offset);
- return 0;
}
u64 sst_shim_read64(void __iomem *addr, int offset)
--
2.11.0
next prev parent reply other threads:[~2017-01-31 14:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 14:14 [PATCH v1 1/4] ASoC: Intel: common: Replace custom implementation of readq / writeq Andy Shevchenko
2017-01-31 14:14 ` [PATCH v1 2/4] ASoC: Intel: hifi2: " Andy Shevchenko
2017-01-31 14:14 ` Andy Shevchenko [this message]
2017-01-31 14:14 ` [PATCH v1 4/4] ASoC: Intel: hifi2: Get rid of snail address in comments Andy Shevchenko
2017-02-03 14:12 ` [PATCH v1 1/4] ASoC: Intel: common: Replace custom implementation of readq / writeq Liam Girdwood
2017-02-06 17:03 ` Vinod Koul
2017-02-08 11:59 ` Andy Shevchenko
2017-02-09 3:56 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170131141425.35482-3-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.