From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Paul Subject: Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board Date: Tue, 31 Jan 2017 09:38:53 -0500 Message-ID: <20170131143853.GU20076@art_vandelay> References: <1484116439-7275-1-git-send-email-hoegeun.kwon@samsung.com> <1484116439-7275-3-git-send-email-hoegeun.kwon@samsung.com> <08c5d94b-c76f-af14-c08f-478e26a34a7c@samsung.com> <588FD3C3.7080508@samsung.com> <20170131085449.GA19348@ulmo.ba.sec> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170131085449.GA19348@ulmo.ba.sec> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, kgene@kernel.org, Donghwa Lee , linux-kernel@vger.kernel.org, andi.shyti@samsung.com, cw00.choi@samsung.com, jh80.chung@samsung.com, dri-devel@lists.freedesktop.org, Hyungwon Hwang , Krzysztof Kozlowski , Hoegeun Kwon List-Id: linux-samsung-soc@vger.kernel.org T24gVHVlLCBKYW4gMzEsIDIwMTcgYXQgMDk6NTQ6NDlBTSArMDEwMCwgVGhpZXJyeSBSZWRpbmcg d3JvdGU6Cj4gT24gVHVlLCBKYW4gMzEsIDIwMTcgYXQgMDk6MDE6MDdBTSArMDkwMCwgSW5raSBE YWUgd3JvdGU6Cj4gPiAKPiA+IAo+ID4gMjAxN+uFhCAwMeyblCAyNOydvCAxMDo1MOyXkCBIb2Vn ZXVuIEt3b24g7J20KOqwgCkg7JO0IOq4gDoKPiA+ID4gRGVhciBUaGllcnJ5LAo+ID4gPiAKPiA+ ID4gQ291bGQgeW91IHBsZWFzZSByZXZpZXcgdGhpcyBwYXRjaD8KPiA+IAo+ID4gVGhpZXJyeSwg SSB0aGluayB0aGlzIHBhdGNoIGhhcyBiZWVuIHJldmlld2VkIGVub3VnaCBidXQgbm8gY29tbWVu dAo+ID4gZnJvbSB5b3UuIFNlZW1zIHlvdSBhcmUgYnVzeS4gSSB3aWxsIHBpY2sgdXAgdGhpcy4K PiAKPiBTb3JyeSwgYnV0IHRoYXQncyBub3QgaG93IGl0IHdvcmtzLiBUaGlzIHBhdGNoIGhhcyBn b25lIHRocm91Z2ggOAo+IHJldmlzaW9ucyB3aXRoaW4gNCB3ZWVrcywgYW5kIEkgdGVuZCB0byBp Z25vcmUgcGF0Y2hlcyBsaWtlIHRoYXQgdW50aWwKPiB0aGUgZHVzdCBzZXR0bGVzLgo+IAoKU2Vl bXMgbGlrZSB0aGUgZHVzdCB3YXMgcHJldHR5IHNldHRsZWQuIEl0IHdhcyBwb3N0ZWQgb24gMS8x MSwgcGluZ2VkIG9uIDEvMjQsCmFuZCBwaWNrZWQgdXAgb24gMS8zMS4gSSBkb24ndCB0aGluayBp dCdzIHVucmVhc29uYWJsZSB0byB0YWtlIGl0IHRocm91Z2gKYW5vdGhlciB0cmVlIGFmdGVyIHRo YXQuCgpJIHdvbmRlciBpZiBkcm1fcGFuZWwgd291bGQgYmVuZWZpdCBmcm9tIHRoZSAtbWlzYyBn cm91cCBtYWludGFpbmVyc2hpcCBtb2RlbAphcyBkcm1fYnJpZGdlIGRvZXMuIEJ5IHNwcmVhZGlu ZyBvdXQgdGhlIHdvcmtsb2FkLCB0aGUgaGlnaC1tYWludGVuYW5jZQpwYXRjaGVzIHdvdWxkIGhv cGVmdWxseSBmaW5kIHNvbWVvbmUgdG8gc2hlcGhlcmQgdGhlbSB0aHJvdWdoLgoKPiBPdGhlciB0 aGFuIHRoYXQsIHRoaXMgY29udGludWVzIHRoZSBzYW1lIG1hZG5lc3MgdGhhdCBJJ3ZlIHJlcGVh dGVkbHkKPiBjb21wbGFpbmVkIGFib3V0IGluIHRoZSBwYXN0LiBUaGUgd2hvbGUgbWVjaGFuaXNt IG9mIHJ1bm5pbmcgdGhyb3VnaCBhCj4gc2VyaWVzIG9mIHdyaXRlcyBhbmQgbm90IGNhcmluZyBh Ym91dCBlcnJvcnMgdW50aWwgdGhlIHZlcnkgZW5kIGlzCj4gc29tZXRoaW5nIHdlJ3ZlIGRpc2N1 c3NlZCBhdCBsZW5ndGggaW4gdGhlIHBhc3QuIEl0IGFsc28gaW4gbGFyZ2UgcGFydHMKPiBkdXBs aWNhdGVzIGEgYnVuY2ggb2YgZnVuY3Rpb25zIGZyb20gb3RoZXIgU2Ftc3VuZyBwYW5lbCBkcml2 ZXJzIHRoYXQgSQo+IGFscmVhZHkgc2FpZCBzaG91bGQgZXZlbnR1YWxseSBiZSBtb3ZlZCB0byBz b21ldGhpbmcgc2FuZXIuCj4gCgpGV0lXLCB0aGlzIHR5cGUgb2YgZXJyb3IgaGFuZGxpbmcgaXNu J3QgbXkgcHJlZmVyZW5jZSBlaXRoZXIuIElmIHdlIG11c3QgZGVmZXIsCkknZCByYXRoZXIgbm90 IGtlZXAgaXQgaW4gY3R4LCBidXQgcmF0aGVyIHBhc3MgYXJvdW5kIGFuIGFyZ3VtZW50IHNvIGl0 J3MgbW9yZQpvYnZpb3VzIHdlIG5lZWQgdG8gZGVhbCB3aXRoIGl0IGluIHRoZSByZXR1cm4uIFRo YXQgc2FpZCwgdGhpcyBzZWVtcyBsaWtlCmEgY2FzZSBvZiBsZXR0aW5nIHRoZSBwZXJmZWN0IGJl IHRoZSBlbmVteSBvZiB0aGUgZ29vZCwgc3VyZWx5IHNvbWV0aGluZyBpcwpiZXR0ZXIgdGhhbiBu b3RoaW5nPwoKU2VhbgoKCgo+IFRoaXMgaXMgbm93IHRoZSB0aGlyZCBkcml2ZXIgYW5kIG5vYm9k eSdzIGdpdmluZyBhIGRhbW4gYWJvdXQgaW1wcm92aW5nCj4gdGhpbmdzLgo+IAo+IFVudGlsIHNv bWVib2R5IGRvZXMsIEknbSBnb2luZyB0byBoYXZlIHRvIE5BSyB0aGlzLgo+IAo+IFRoaWVycnkK PiAKCjxzbmlwPgoKLS0gClNlYW4gUGF1bCwgU29mdHdhcmUgRW5naW5lZXIsIEdvb2dsZSAvIENo cm9taXVtIE9TCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751142AbdAaOjc (ORCPT ); Tue, 31 Jan 2017 09:39:32 -0500 Received: from mail-qt0-f176.google.com ([209.85.216.176]:36114 "EHLO mail-qt0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750801AbdAaOjY (ORCPT ); Tue, 31 Jan 2017 09:39:24 -0500 Date: Tue, 31 Jan 2017 09:38:53 -0500 From: Sean Paul To: Thierry Reding Cc: Inki Dae , linux-samsung-soc@vger.kernel.org, cw00.choi@samsung.com, andi.shyti@samsung.com, devicetree@vger.kernel.org, Donghwa Lee , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, jh80.chung@samsung.com, kgene@kernel.org, Krzysztof Kozlowski , Hyungwon Hwang , Hoegeun Kwon Subject: Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board Message-ID: <20170131143853.GU20076@art_vandelay> References: <1484116439-7275-1-git-send-email-hoegeun.kwon@samsung.com> <1484116439-7275-3-git-send-email-hoegeun.kwon@samsung.com> <08c5d94b-c76f-af14-c08f-478e26a34a7c@samsung.com> <588FD3C3.7080508@samsung.com> <20170131085449.GA19348@ulmo.ba.sec> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170131085449.GA19348@ulmo.ba.sec> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 31, 2017 at 09:54:49AM +0100, Thierry Reding wrote: > On Tue, Jan 31, 2017 at 09:01:07AM +0900, Inki Dae wrote: > > > > > > 2017년 01월 24일 10:50에 Hoegeun Kwon 이(가) 쓴 글: > > > Dear Thierry, > > > > > > Could you please review this patch? > > > > Thierry, I think this patch has been reviewed enough but no comment > > from you. Seems you are busy. I will pick up this. > > Sorry, but that's not how it works. This patch has gone through 8 > revisions within 4 weeks, and I tend to ignore patches like that until > the dust settles. > Seems like the dust was pretty settled. It was posted on 1/11, pinged on 1/24, and picked up on 1/31. I don't think it's unreasonable to take it through another tree after that. I wonder if drm_panel would benefit from the -misc group maintainership model as drm_bridge does. By spreading out the workload, the high-maintenance patches would hopefully find someone to shepherd them through. > Other than that, this continues the same madness that I've repeatedly > complained about in the past. The whole mechanism of running through a > series of writes and not caring about errors until the very end is > something we've discussed at length in the past. It also in large parts > duplicates a bunch of functions from other Samsung panel drivers that I > already said should eventually be moved to something saner. > FWIW, this type of error handling isn't my preference either. If we must defer, I'd rather not keep it in ctx, but rather pass around an argument so it's more obvious we need to deal with it in the return. That said, this seems like a case of letting the perfect be the enemy of the good, surely something is better than nothing? Sean > This is now the third driver and nobody's giving a damn about improving > things. > > Until somebody does, I'm going to have to NAK this. > > Thierry > -- Sean Paul, Software Engineer, Google / Chromium OS