From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Gross Subject: Re: [Patch v4 2/2] firmware: qcom: scm: Fix interrupted SCM calls Date: Tue, 31 Jan 2017 10:03:51 -0600 Message-ID: <20170131160351.GC2821@hector.attlocal.net> References: <1484845120-3364-1-git-send-email-andy.gross@linaro.org> <1484845120-3364-3-git-send-email-andy.gross@linaro.org> <20170130105553.GB16461@arm.com> <20170131144539.GE22283@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20170131144539.GE22283@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Will Deacon Cc: Lorenzo Pieralisi , linux-arm-msm , "linux-kernel@vger.kernel.org" , Bjorn Andersson , Kevin Hilman , Olof Johansson , Russell King , "linux-arm-kernel@lists.infradead.org" List-Id: linux-arm-msm@vger.kernel.org On Tue, Jan 31, 2017 at 02:45:39PM +0000, Will Deacon wrote: > On Mon, Jan 30, 2017 at 10:22:18PM -0800, Olof Johansson wrote: > > On Mon, Jan 30, 2017 at 2:55 AM, Will Deacon wrote: > > > On Sun, Jan 29, 2017 at 04:24:51PM -0800, Olof Johansson wrote: > > >> Seems like a more appropriate change than burden all platforms with > > >> longer code path due to your quirk. > > > > > > I really don't think it's a problem. Do you have numbers suggesting > > > otherwise? > > > > Not on this first quirk, no. > > > > Anyway, I guess I'm just bikeshedding. You should merge this code if > > you're happy with it. > > Ok. Andy, does it work for you if I take these two patches via arm64? I'll > need Russell's ack on the arch/arm/ part. FYI, there is a new version that fixes an issue with hvc. I missed this as we don't exercise that code path. As for taking it via arm64, that's fine. I'm not sure how to get his ACK aside from emailing the patches. Andy From mboxrd@z Thu Jan 1 00:00:00 1970 From: andy.gross@linaro.org (Andy Gross) Date: Tue, 31 Jan 2017 10:03:51 -0600 Subject: [Patch v4 2/2] firmware: qcom: scm: Fix interrupted SCM calls In-Reply-To: <20170131144539.GE22283@arm.com> References: <1484845120-3364-1-git-send-email-andy.gross@linaro.org> <1484845120-3364-3-git-send-email-andy.gross@linaro.org> <20170130105553.GB16461@arm.com> <20170131144539.GE22283@arm.com> Message-ID: <20170131160351.GC2821@hector.attlocal.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jan 31, 2017 at 02:45:39PM +0000, Will Deacon wrote: > On Mon, Jan 30, 2017 at 10:22:18PM -0800, Olof Johansson wrote: > > On Mon, Jan 30, 2017 at 2:55 AM, Will Deacon wrote: > > > On Sun, Jan 29, 2017 at 04:24:51PM -0800, Olof Johansson wrote: > > >> Seems like a more appropriate change than burden all platforms with > > >> longer code path due to your quirk. > > > > > > I really don't think it's a problem. Do you have numbers suggesting > > > otherwise? > > > > Not on this first quirk, no. > > > > Anyway, I guess I'm just bikeshedding. You should merge this code if > > you're happy with it. > > Ok. Andy, does it work for you if I take these two patches via arm64? I'll > need Russell's ack on the arch/arm/ part. FYI, there is a new version that fixes an issue with hvc. I missed this as we don't exercise that code path. As for taking it via arm64, that's fine. I'm not sure how to get his ACK aside from emailing the patches. Andy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751498AbdAaQE1 (ORCPT ); Tue, 31 Jan 2017 11:04:27 -0500 Received: from mail-oi0-f52.google.com ([209.85.218.52]:35584 "EHLO mail-oi0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751436AbdAaQEI (ORCPT ); Tue, 31 Jan 2017 11:04:08 -0500 Date: Tue, 31 Jan 2017 10:03:51 -0600 From: Andy Gross To: Will Deacon Cc: Olof Johansson , Lorenzo Pieralisi , linux-arm-msm , "linux-kernel@vger.kernel.org" , Bjorn Andersson , Kevin Hilman , Russell King , "linux-arm-kernel@lists.infradead.org" Subject: Re: [Patch v4 2/2] firmware: qcom: scm: Fix interrupted SCM calls Message-ID: <20170131160351.GC2821@hector.attlocal.net> References: <1484845120-3364-1-git-send-email-andy.gross@linaro.org> <1484845120-3364-3-git-send-email-andy.gross@linaro.org> <20170130105553.GB16461@arm.com> <20170131144539.GE22283@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170131144539.GE22283@arm.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 31, 2017 at 02:45:39PM +0000, Will Deacon wrote: > On Mon, Jan 30, 2017 at 10:22:18PM -0800, Olof Johansson wrote: > > On Mon, Jan 30, 2017 at 2:55 AM, Will Deacon wrote: > > > On Sun, Jan 29, 2017 at 04:24:51PM -0800, Olof Johansson wrote: > > >> Seems like a more appropriate change than burden all platforms with > > >> longer code path due to your quirk. > > > > > > I really don't think it's a problem. Do you have numbers suggesting > > > otherwise? > > > > Not on this first quirk, no. > > > > Anyway, I guess I'm just bikeshedding. You should merge this code if > > you're happy with it. > > Ok. Andy, does it work for you if I take these two patches via arm64? I'll > need Russell's ack on the arch/arm/ part. FYI, there is a new version that fixes an issue with hvc. I missed this as we don't exercise that code path. As for taking it via arm64, that's fine. I'm not sure how to get his ACK aside from emailing the patches. Andy