From: "Daniel P. Berrange" <berrange@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
Paolo Bonzini <pbonzini@redhat.com>,
patches@linaro.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] Drop QEMU_GNUC_PREREQ() checks for gcc older than 4.1
Date: Tue, 31 Jan 2017 16:55:57 +0000 [thread overview]
Message-ID: <20170131165557.GE20303@redhat.com> (raw)
In-Reply-To: <1485879287-12548-1-git-send-email-peter.maydell@linaro.org>
On Tue, Jan 31, 2017 at 04:14:47PM +0000, Peter Maydell wrote:
> We already require gcc 4.1 or newer (for the atomic
> support), so the fallback codepaths for older gcc
> versions than that are now dead code and we can
> just delete them.
Do we have any explicit check alreadu for 4.1, or do we
just let the build fail on the atomic code ?
IOW, is there any use in having..
#if !QEMU_GNUC_PREREQ(4, 1)
# error "QEMU requires GCC >= 4.1 or CLang"
#endif
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
WARNING: multiple messages have this Message-ID (diff)
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
Paolo Bonzini <pbonzini@redhat.com>,
patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] Drop QEMU_GNUC_PREREQ() checks for gcc older than 4.1
Date: Tue, 31 Jan 2017 16:55:57 +0000 [thread overview]
Message-ID: <20170131165557.GE20303@redhat.com> (raw)
In-Reply-To: <1485879287-12548-1-git-send-email-peter.maydell@linaro.org>
On Tue, Jan 31, 2017 at 04:14:47PM +0000, Peter Maydell wrote:
> We already require gcc 4.1 or newer (for the atomic
> support), so the fallback codepaths for older gcc
> versions than that are now dead code and we can
> just delete them.
Do we have any explicit check alreadu for 4.1, or do we
just let the build fail on the atomic code ?
IOW, is there any use in having..
#if !QEMU_GNUC_PREREQ(4, 1)
# error "QEMU requires GCC >= 4.1 or CLang"
#endif
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
next prev parent reply other threads:[~2017-01-31 16:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 16:14 [Qemu-trivial] [PATCH] Drop QEMU_GNUC_PREREQ() checks for gcc older than 4.1 Peter Maydell
2017-01-31 16:14 ` [Qemu-devel] " Peter Maydell
2017-01-31 16:55 ` Daniel P. Berrange [this message]
2017-01-31 16:55 ` Daniel P. Berrange
2017-01-31 16:58 ` [Qemu-trivial] " Peter Maydell
2017-01-31 16:58 ` Peter Maydell
2017-01-31 23:27 ` [Qemu-trivial] " Paolo Bonzini
2017-01-31 23:27 ` Paolo Bonzini
2017-01-31 17:40 ` [Qemu-trivial] " Markus Armbruster
2017-01-31 17:40 ` Markus Armbruster
2017-01-31 18:00 ` [Qemu-trivial] " Peter Maydell
2017-01-31 18:00 ` Peter Maydell
2017-01-31 18:11 ` [Qemu-trivial] " Daniel P. Berrange
2017-01-31 18:11 ` Daniel P. Berrange
2017-01-31 18:32 ` [Qemu-trivial] " Peter Maydell
2017-01-31 18:32 ` Peter Maydell
2017-01-31 19:02 ` [Qemu-trivial] " Markus Armbruster
2017-01-31 19:02 ` Markus Armbruster
2017-01-31 18:58 ` [Qemu-trivial] " Markus Armbruster
2017-01-31 18:58 ` Markus Armbruster
2017-01-31 23:27 ` [Qemu-trivial] " Paolo Bonzini
2017-01-31 23:27 ` Paolo Bonzini
2017-02-01 6:49 ` [Qemu-trivial] " Markus Armbruster
2017-02-01 6:49 ` Markus Armbruster
2017-02-02 1:09 ` [Qemu-trivial] " Paolo Bonzini
2017-02-02 1:09 ` Paolo Bonzini
2017-02-02 10:17 ` [Qemu-trivial] " Markus Armbruster
2017-02-02 10:17 ` Markus Armbruster
2017-04-21 9:08 ` [Qemu-trivial] " Peter Maydell
2017-04-21 9:08 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170131165557.GE20303@redhat.com \
--to=berrange@redhat.com \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.